Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2348373002: AudioBufferSourceOptions.buffer should be nullable. (Closed)

Created:
4 years, 3 months ago by Raymond Toy
Modified:
4 years, 3 months ago
Reviewers:
tkent, hongchan
CC:
blink-reviews, chromium-reviews, haraken, hongchan, Raymond Toy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioBufferSourceOptions.buffer should be nullable. It's valid to set the buffer to null in the constructor. Also added a test for ConvolverOptions which has the same issue, which was updated in https://codereview.chromium.org/2352463002/ Spec issue: https://github.com/WebAudio/web-audio-api/issues/980 BUG=648283, 626449, 647693 TEST=constructor/audiobuffersource.html, constructor/convolver.html Committed: https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e Cr-Commit-Position: refs/heads/master@{#419830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBufferSourceOptions.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Raymond Toy
PTAL.
4 years, 3 months ago (2016-09-19 16:58:36 UTC) #4
hongchan
lgtm
4 years, 3 months ago (2016-09-19 17:18:15 UTC) #5
Raymond Toy
tkent: PTAL as this really trivial web-exposed change. It is valid to call both constructors ...
4 years, 3 months ago (2016-09-19 17:31:48 UTC) #8
tkent
lgtm
4 years, 3 months ago (2016-09-20 00:36:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348373002/1
4 years, 3 months ago (2016-09-20 16:46:13 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 18:53:02 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 18:56:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e
Cr-Commit-Position: refs/heads/master@{#419830}

Powered by Google App Engine
This is Rietveld 408576698