Chromium Code Reviews
DescriptionAudioBufferSourceOptions.buffer should be nullable.
It's valid to set the buffer to null in the constructor.
Also added a test for ConvolverOptions which has the same issue, which
was updated in https://codereview.chromium.org/2352463002/
Spec issue: https://github.com/WebAudio/web-audio-api/issues/980
BUG=648283, 626449, 647693
TEST=constructor/audiobuffersource.html, constructor/convolver.html
Committed: https://crrev.com/2582f835f9351586c831e87b0cf69318cf6c971e
Cr-Commit-Position: refs/heads/master@{#419830}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
|
|||||||||||||||||||||||||||||||||||||