Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html

Issue 2348373002: AudioBufferSourceOptions.buffer should be nullable. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html b/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
index 1b2b33f3eec347244576166f757f946c586044dc..bb7a40f057769a51072108cc7bb843e4958a8fda 100644
--- a/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html
@@ -74,6 +74,27 @@
taskDone();
});
+ audit.defineTask("nullable buffer", function (taskDone) {
+ var node;
+ var success = true;
+
+ var options = { buffer: null };
+
+ success = Should("node = new ConvolverNode(c, " + JSON.stringify(options), function () {
+ node = new ConvolverNode(context, options);
+ }).notThrow();
+
+ success = Should("node.buffer", node.buffer)
+ .beEqualTo(null);
+
+ Should("Null buffer in constructor handled", success)
+ .summarize(
+ "correctly",
+ "incorrectly");
+
+ taskDone();
+ });
+
audit.defineTask("construct with options", function (taskDone) {
var buf = context.createBuffer(1, 1, context.sampleRate);
var options = {

Powered by Google App Engine
This is Rietveld 408576698