Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2538)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html

Issue 2348373002: AudioBufferSourceOptions.buffer should be nullable. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html b/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
index e57506c44b219484f88fa303e3d227ec8078dc6e..ffb0364651424cf14caf8b3754f42b828004cbc5 100644
--- a/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/audiobuffersource.html
@@ -83,6 +83,27 @@
taskDone();
});
+ audit.defineTask("nullable buffer", function (taskDone) {
+ var node;
+ var success = true;
+
+ var options = { buffer: null };
+
+ success = Should("node = new AudioBufferSourceNode(c, " + JSON.stringify(options), function () {
+ node = new AudioBufferSourceNode(context, options);
+ }).notThrow();
+
+ success = Should("node.buffer", node.buffer)
+ .beEqualTo(null);
+
+ Should("Null buffer in constructor handled", success)
+ .summarize(
+ "correctly",
+ "incorrectly");
+
+ taskDone();
+ });
+
audit.defineTask("constructor options", function (taskDone) {
var node;
var success = true;
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/constructor/convolver.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698