Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2348333002: Revert of [sensors] Ambient light sensor bindings implementation (Closed)

Created:
4 years, 3 months ago by iclelland
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sensors] Ambient light sensor bindings implementation (patchset #5 id:80001 of https://codereview.chromium.org/2332323002/ ) Reason for revert: Sorry for the revert -- two new tests are failing immediately on several Blink bots: sensor/mock-sensor.html sensor/ambient-light-sensor.html See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=sensor%2Fambient-light-sensor.html%2C%20sensor%2Fmock-sensor.html First failed build on MacOS 10.10: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/23859 Original issue's description: > [sensors] Ambient light sensor bindings implementation > > This patch implements AmbientLightSensor [1] blink bindings and adds > LayoutTest helpers for testing sensors that are based on Generic Sensor API. > > Following layout tests added to test new functionality: > IDL tests. > - third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html > - third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html > AmbientLightSensor tests. > - third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html > > Intent to Implement: > https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xLGN2b1-AAAJ > > [1] ED specification for Ambient Light Sensor http://w3c.github.io/ambient-light/ > > BUG=606766 > > Committed: https://crrev.com/c457d06894e8f01b24ae83750203fb5d8819c560 > Cr-Commit-Position: refs/heads/master@{#419438} TBR=jochen@chromium.org,haraken@chromium.org,mikhail.pozdnyakov@intel.com,rijubrata.bhaumik@intel.com,timvolodine@chromium.org,alexander.shalamov@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606766 Committed: https://crrev.com/a7e4b7e260983b75067aacdbd55c5182675c4829 Cr-Commit-Position: refs/heads/master@{#419453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -770 lines) Patch
D third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html View 1 chunk +0 lines, -189 lines 0 comments Download
D third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensor.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/sensor/idl-AmbientLightSensorReading.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/sensor/mock-sensor.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js View 1 chunk +0 lines, -302 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 3 chunks +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensor.h View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensor.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensor.idl View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensorReading.idl View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/modules/sensor/AmbientLightSensorReadingInit.idl View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorReading.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorReading.cpp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iclelland
Created Revert of [sensors] Ambient light sensor bindings implementation
4 years, 3 months ago (2016-09-19 14:41:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348333002/1
4 years, 3 months ago (2016-09-19 14:41:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 14:42:27 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a7e4b7e260983b75067aacdbd55c5182675c4829 Cr-Commit-Position: refs/heads/master@{#419453}
4 years, 3 months ago (2016-09-19 14:44:53 UTC) #7
haraken
4 years, 3 months ago (2016-09-20 00:40:09 UTC) #8
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698