Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: third_party/WebKit/Source/modules/sensor/SensorReading.cpp

Issue 2348333002: Revert of [sensors] Ambient light sensor bindings implementation (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/SensorReading.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/sensor/SensorReading.h" 5 #include "modules/sensor/SensorReading.h"
6 6
7 #include "core/dom/ExecutionContext.h" 7 #include "core/dom/ExecutionContext.h"
8 #include "core/frame/LocalDOMWindow.h" 8 #include "core/frame/LocalDOMWindow.h"
9 #include "core/timing/DOMWindowPerformance.h" 9 #include "core/timing/DOMWindowPerformance.h"
10 #include "core/timing/Performance.h" 10 #include "core/timing/Performance.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 SensorReading::SensorReading(SensorProxy* sensorProxy) 14 SensorReading::SensorReading(SensorProxy* sensorProxy)
15 : m_sensorProxy(sensorProxy) 15 : m_sensorProxy(sensorProxy)
16 { 16 {
17 DCHECK(m_sensorProxy);
17 } 18 }
18 19
19 DEFINE_TRACE(SensorReading) 20 DEFINE_TRACE(SensorReading)
20 { 21 {
21 visitor->trace(m_sensorProxy); 22 visitor->trace(m_sensorProxy);
22 } 23 }
23 24
24 DOMHighResTimeStamp SensorReading::timeStamp(ScriptState* scriptState) const 25 DOMHighResTimeStamp SensorReading::timeStamp(ScriptState* scriptState) const
25 { 26 {
26 LocalDOMWindow* window = scriptState->domWindow(); 27 LocalDOMWindow* window = scriptState->domWindow();
27 if (!window) 28 if (!window)
28 return 0.0; 29 return 0.0;
29 30
30 Performance* performance = DOMWindowPerformance::performance(*window); 31 Performance* performance = DOMWindowPerformance::performance(*window);
31 DCHECK(performance); 32 DCHECK(performance);
32 33
33 if (!m_sensorProxy) {
34 // In cases when SensorReading derived classes are constructed from JS
35 // side, e.g. to create syntetic SensorReadingEvent for testing
36 // purposes, |m_sensorProxy| will be null and SensorReading.timeStamp
37 // would return current DOMHighResTimeStamp, while reading value should
38 // be provided by derived classes.
39 return performance->now();
40 }
41
42 return performance->monotonicTimeToDOMHighResTimeStamp(m_sensorProxy->readin g().timestamp); 34 return performance->monotonicTimeToDOMHighResTimeStamp(m_sensorProxy->readin g().timestamp);
43 } 35 }
44 36
45 } // namespace blink 37 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/sensor/SensorReading.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698