Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 234833003: Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (Closed)

Created:
6 years, 8 months ago by benchen
Modified:
6 years, 8 months ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Rename kPMColor_SkColorType to kN32_SkColorType. (https://codereview.chromium.org/227433009/) Reason for revert: Chrome's side of define changes not easy to figure out quickly. Reverting this for DEPS roll for now. Original issue's description: > Rename kPMColor_SkColorType to kN32_SkColorType. > > The new name better represents what this flag means. > > BUG=skia:2384 > > Committed: http://code.google.com/p/skia/source/detail?r=14117 TBR=reed@google.com,scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2384 Committed: http://code.google.com/p/skia/source/detail?r=14149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -133 lines) Patch
M bench/DeferredSurfaceCopyBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/benchmain.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M debugger/QT/SkImageWidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DM.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DMBenchTask.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DMGpuGMTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/iOSSampleApp/Shared/SkUIView.mm View 1 chunk +1 line, -1 line 0 comments Download
M experimental/iOSSampleApp/SkSampleUIView.mm View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapcopy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmappremul.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/gammatext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gmmain.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/tilemodes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageInfo.h View 3 chunks +4 lines, -8 lines 0 comments Download
M samplecode/SampleApp.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleDitherBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleEncode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleTiling.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter_Sprite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDraw.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSpriteBlitter_ARGB32.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkSpriteBlitter_RGB16.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTransparentShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImagePriv.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Picture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkImageDecoder_CG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkImageDecoder_WIC.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkBitmapHasher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkCanvasStateUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/mac/SkCreateCGImageRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/views/SkWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/mac/SkNSView.mm View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/BitmapGetColorTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/BitmapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BlitRowTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/CanvasStateTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skdiff_utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skimage_main.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/skpdiff/SkDiffContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/skpdiff/SkPMetric.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
benchen
Created Revert of Rename kPMColor_SkColorType to kN32_SkColorType.
6 years, 8 months ago (2014-04-11 13:46:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/234833003/1
6 years, 8 months ago (2014-04-11 13:46:47 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 13:49:18 UTC) #3
Message was sent while issue was closed. 
Change committed as 14149

Powered by Google App Engine
This is Rietveld 408576698