Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2348183002: App list: Remove search box menu (dead code). (Closed)

Created:
4 years, 3 months ago by Matt Giuca
Modified:
4 years, 3 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, Matt Giuca, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

App list: Remove search box menu (dead code). The menu was used in the non-Chrome-OS app list, but is never shown in Chrome OS. Since the launcher is no longer available on non-Chrome-OS, this can be deleted. BUG=600915 Committed: https://crrev.com/95d3bea43a44c1c3830b6f206ed9d5359a7151bf Cr-Commit-Position: refs/heads/master@{#420545}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -289 lines) Patch
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/app_list/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D ui/app_list/app_list_menu.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ui/app_list/app_list_menu.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M ui/app_list/app_list_view_delegate_observer.h View 1 chunk +1 line, -4 lines 0 comments Download
D ui/app_list/views/app_list_menu_views.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/app_list/views/app_list_menu_views.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/app_list/views/search_box_view.h View 6 chunks +0 lines, -13 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 8 chunks +1 line, -39 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Matt Giuca
4 years, 3 months ago (2016-09-19 05:42:02 UTC) #2
benwells
lgtm
4 years, 3 months ago (2016-09-19 06:40:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348183002/20001
4 years, 3 months ago (2016-09-23 01:12:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 02:18:29 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 02:19:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95d3bea43a44c1c3830b6f206ed9d5359a7151bf
Cr-Commit-Position: refs/heads/master@{#420545}

Powered by Google App Engine
This is Rietveld 408576698