Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2350623002: Deleted AppListViewDelegateObserver class (was unused). (Closed)

Created:
4 years, 3 months ago by Matt Giuca
Modified:
4 years, 3 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, Matt Giuca, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deleted AppListViewDelegateObserver class (was unused). BUG=600915 Committed: https://crrev.com/dce5e75f9a733e24f2a48bd1162d6a271060902d Cr-Commit-Position: refs/heads/master@{#420559}

Patch Set 1 #

Total comments: 4

Patch Set 2 : More cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -77 lines) Patch
M chrome/browser/ui/app_list/app_list_view_delegate.h View 1 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M ui/app_list/app_list_view_delegate.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
D ui/app_list/app_list_view_delegate_observer.h View 1 chunk +0 lines, -26 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M ui/app_list/test/app_list_test_view_delegate.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Matt Giuca
4 years, 3 months ago (2016-09-19 05:42:49 UTC) #2
tapted
lgtm % comments of course.. we can remove the whole profile switcher too.. but this ...
4 years, 3 months ago (2016-09-19 07:28:58 UTC) #3
Matt Giuca
https://codereview.chromium.org/2350623002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.h File chrome/browser/ui/app_list/app_list_view_delegate.h (right): https://codereview.chromium.org/2350623002/diff/1/chrome/browser/ui/app_list/app_list_view_delegate.h#newcode18 chrome/browser/ui/app_list/app_list_view_delegate.h:18: #include "base/observer_list.h" On 2016/09/19 07:28:58, tapted wrote: > remove ...
4 years, 3 months ago (2016-09-21 03:41:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350623002/40001
4 years, 3 months ago (2016-09-23 02:41:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-23 03:08:25 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 03:11:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dce5e75f9a733e24f2a48bd1162d6a271060902d
Cr-Commit-Position: refs/heads/master@{#420559}

Powered by Google App Engine
This is Rietveld 408576698