Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2348103002: PaymentRequest: Add support for payerName. (in blink side) (Closed)

Created:
4 years, 3 months ago by zino
Modified:
4 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, dglazkov+blink, blink-reviews, darin (slow to review), blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentRequest: Add support for payerName. (in blink side) Support collection of payer name without shipping address. This CL is a initial implementation for requestPayerName in blink side. So, it's behind a runtime flag to avoid breaking existing behavior. If once we implement the related UI, then can remove the flag. Related spec change: https://github.com/w3c/browser-payment-api/pull/270 BUG=648051 Committed: https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d Cr-Commit-Position: refs/heads/master@{#420255}

Patch Set 1 #

Patch Set 2 : test #

Total comments: 4

Patch Set 3 : PaymentRequest: Add support for payerName. (in blink side) #

Total comments: 3

Messages

Total messages: 45 (20 generated)
zino
PTAL
4 years, 3 months ago (2016-09-18 14:21:14 UTC) #5
please use gerrit instead
Please add to the description information about the flag why you're adding it. I assume ...
4 years, 3 months ago (2016-09-19 08:06:31 UTC) #10
zino
I addressed your comments. Thank you for review! PTAL https://codereview.chromium.org/2348103002/diff/20001/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp File third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp (right): https://codereview.chromium.org/2348103002/diff/20001/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp#newcode400 third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp:400: ...
4 years, 3 months ago (2016-09-19 13:26:08 UTC) #12
please use gerrit instead
lgtm
4 years, 3 months ago (2016-09-19 13:38:18 UTC) #13
zino
Hi, Philip PTAL. Do we need a intent to implement and ship for this patch?
4 years, 3 months ago (2016-09-19 14:23:17 UTC) #15
please use gerrit instead
On 2016/09/19 14:23:17, zino wrote: > Do we need a intent to implement and ship ...
4 years, 3 months ago (2016-09-19 14:30:18 UTC) #16
zino
On 2016/09/19 14:30:18, rouslan wrote: > On 2016/09/19 14:23:17, zino wrote: > > Do we ...
4 years, 3 months ago (2016-09-19 14:40:06 UTC) #17
zino
+ haraken@ for Source/platform/* + foolip@ for Source/public/* PTAL.
4 years, 3 months ago (2016-09-19 14:41:29 UTC) #19
foolip
lgtm % nit, rouslan@ can say whether the extra feature is really needed. https://codereview.chromium.org/2348103002/diff/40001/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp File ...
4 years, 3 months ago (2016-09-19 15:34:40 UTC) #20
please use gerrit instead
On 2016/09/19 15:34:40, foolip wrote: > rouslan@ can say whether the extra feature is really ...
4 years, 3 months ago (2016-09-19 15:46:33 UTC) #21
foolip
On 2016/09/19 15:46:33, rouslan wrote: > On 2016/09/19 15:34:40, foolip wrote: > > rouslan@ can ...
4 years, 3 months ago (2016-09-19 16:03:01 UTC) #22
please use gerrit instead
On 2016/09/19 16:03:01, foolip wrote: > On 2016/09/19 15:46:33, rouslan wrote: > > On 2016/09/19 ...
4 years, 3 months ago (2016-09-19 16:18:27 UTC) #23
foolip
On 2016/09/19 16:18:27, rouslan wrote: > On 2016/09/19 16:03:01, foolip wrote: > > On 2016/09/19 ...
4 years, 3 months ago (2016-09-19 16:23:48 UTC) #24
haraken
platform/ LGTM
4 years, 3 months ago (2016-09-20 00:42:51 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348103002/40001
4 years, 3 months ago (2016-09-20 01:41:23 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262586)
4 years, 3 months ago (2016-09-20 01:49:39 UTC) #29
zino
+ dcheng@ for public/platform/modules/payments/payment_request.mojom That's set no parent. PTAL.
4 years, 3 months ago (2016-09-20 02:59:25 UTC) #31
zino
+ Will Harris for public/platform/modules/payments/payment_request.mojom PTAL
4 years, 3 months ago (2016-09-20 17:31:50 UTC) #33
dcheng
https://codereview.chromium.org/2348103002/diff/40001/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp File third_party/WebKit/Source/modules/payments/PaymentResponse.cpp (right): https://codereview.chromium.org/2348103002/diff/40001/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp#newcode19 third_party/WebKit/Source/modules/payments/PaymentResponse.cpp:19: , m_payerName(response->payer_name) Can we write a StructTrait to do ...
4 years, 3 months ago (2016-09-20 19:39:09 UTC) #34
Will Harris
looks like dcheng is reviewing. in future don't add more reviewers, as then it's hard ...
4 years, 3 months ago (2016-09-20 21:30:41 UTC) #35
zino
On 2016/09/20 19:39:09, dcheng wrote: > https://codereview.chromium.org/2348103002/diff/40001/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp > File third_party/WebKit/Source/modules/payments/PaymentResponse.cpp (right): > > https://codereview.chromium.org/2348103002/diff/40001/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp#newcode19 > ...
4 years, 3 months ago (2016-09-21 16:58:26 UTC) #37
dcheng
LGTM, thanks
4 years, 3 months ago (2016-09-22 00:39:05 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348103002/40001
4 years, 3 months ago (2016-09-22 02:08:43 UTC) #40
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 03:44:40 UTC) #42
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 03:49:08 UTC) #44
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e25ee6c8c02d34d0176db8db484af8fb92cbab0d
Cr-Commit-Position: refs/heads/master@{#420255}

Powered by Google App Engine
This is Rietveld 408576698