PaymentRequest: Add support for payerName. (in blink side)

third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Tests for PaymentRequest::OnPaymentResponse().
 
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "bindings/modules/v8/V8PaymentResponse.h"
 #include "modules/payments/PaymentAddress.h"
@@ skipping 39 matching lines @@
     PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
     ASSERT_FALSE(scope.getExceptionState().hadException());
     mojom::blink::PaymentResponsePtr response = buildPaymentResponseForTest();
     response->shipping_option = "standardShipping";
 
     request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
 
     static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
 }
 
+// If the merchant requests a payer name, but the browser does not provide it,
+// reject the show() promise.
+TEST(OnPaymentResponseTest, RejectMissingName)
+{
+    V8TestingScope scope;
+    PaymentRequestMockFunctionScope funcs(scope.getScriptState());
+    makePaymentRequestOriginSecure(scope.document());
+    PaymentOptions options;
+    options.setRequestPayerName(true);
+    PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
+    EXPECT_FALSE(scope.getExceptionState().hadException());
+    mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
+
+    request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
+
+    static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
+}
+
 // If the merchant requests an email address, but the browser does not provide
 // it, reject the show() promise.
 TEST(OnPaymentResponseTest, RejectMissingEmail)
 {
     V8TestingScope scope;
     PaymentRequestMockFunctionScope funcs(scope.getScriptState());
     makePaymentRequestOriginSecure(scope.document());
     PaymentOptions options;
     options.setRequestPayerEmail(true);
     PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
@@ skipping 59 matching lines @@
     ASSERT_FALSE(scope.getExceptionState().hadException());
     mojom::blink::PaymentResponsePtr response = buildPaymentResponseForTest();
     response->shipping_option = "standardShipping";
     response->shipping_address = mojom::blink::PaymentAddress::New();
 
     request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
 
     static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
 }
 
+// If the merchant requests a payer name, but the browser provides an empty
+// string for name, reject the show() promise.
+TEST(OnPaymentResponseTest, RejectEmptyName)
+{
+    V8TestingScope scope;
+    PaymentRequestMockFunctionScope funcs(scope.getScriptState());
+    makePaymentRequestOriginSecure(scope.document());
+    PaymentOptions options;
+    options.setRequestPayerName(true);
+    PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
+    EXPECT_FALSE(scope.getExceptionState().hadException());
+    mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
+    response->payer_name = "";
+
+    request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
+
+    static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
+}
+
 // If the merchant requests an email, but the browser provides an empty string
 // for email, reject the show() promise.
 TEST(OnPaymentResponseTest, RejectEmptyEmail)
 {
     V8TestingScope scope;
     PaymentRequestMockFunctionScope funcs(scope.getScriptState());
     makePaymentRequestOriginSecure(scope.document());
     PaymentOptions options;
     options.setRequestPayerEmail(true);
     PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
@@ skipping 59 matching lines @@
     PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
     ASSERT_FALSE(scope.getExceptionState().hadException());
     mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
     response->shipping_option = "";
 
     request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
 
     static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
 }
 
+// If the merchant does not request a payer name, but the browser provides it,
+// reject the show() promise.
+TEST(OnPaymentResponseTest, RejectNotRequestedName)
+{
+    V8TestingScope scope;
+    PaymentRequestMockFunctionScope funcs(scope.getScriptState());
+    makePaymentRequestOriginSecure(scope.document());
+    PaymentOptions options;
+    options.setRequestPayerName(false);
+    PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
+    EXPECT_FALSE(scope.getExceptionState().hadException());
+    mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
+    response->payer_name = "";
+
+    request->show(scope.getScriptState()).then(funcs.expectNoCall(), funcs.expectCall());
+
+    static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
+}
+
 // If the merchant does not request an email, but the browser provides it,
 // reject the show() promise.
 TEST(OnPaymentResponseTest, RejectNotRequestedEmail)
 {
     V8TestingScope scope;
     PaymentRequestMockFunctionScope funcs(scope.getScriptState());
     makePaymentRequestOriginSecure(scope.document());
     PaymentOptions options;
     options.setRequestPayerEmail(false);
     PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
@@ skipping 94 matching lines @@
 
     static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
 
     v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
     PaymentResponse* resp = V8PaymentResponse::toImplWithTypeCheck(scope.isolate(), outValue.v8Value());
     EXPECT_EQ("standardShipping", resp->shippingOption());
     EXPECT_EQ("US", resp->shippingAddress()->country());
     EXPECT_EQ("en-Latn", resp->shippingAddress()->languageCode());
 }
 
+// If the merchant requests a payer name, the resolved show() promise should
+// contain a payer name.
+TEST(OnPaymentResponseTest, CanRequestName)
+{
+    V8TestingScope scope;
+    PaymentRequestMockFunctionScope funcs(scope.getScriptState());
+    makePaymentRequestOriginSecure(scope.document());
+    PaymentOptions options;
+    options.setRequestPayerName(true);
+    PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
+    EXPECT_FALSE(scope.getExceptionState().hadException());
+    mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
+    response->payer_name = "Torvalds";

[please use gerrit instead, 2016/09/19 08:06:31]

We prefer to use made up names like "Jon Doe" in code.

[zino, 2016/09/19 13:26:08]

Done.

+    ScriptValue outValue;
+    request->show(scope.getScriptState()).then(PaymentResponseFunction::create(scope.getScriptState(), &outValue), funcs.expectNoCall());
+
+    static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
+
+    v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
+    PaymentResponse* pr = V8PaymentResponse::toImplWithTypeCheck(scope.isolate(), outValue.v8Value());
+    EXPECT_EQ("Torvalds", pr->payerName());
+}
+
 // If the merchant requests an email address, the resolved show() promise should
 // contain an email address.
 TEST(OnPaymentResponseTest, CanRequestEmail)
 {
     V8TestingScope scope;
     PaymentRequestMockFunctionScope funcs(scope.getScriptState());
     makePaymentRequestOriginSecure(scope.document());
     PaymentOptions options;
     options.setRequestPayerEmail(true);
     PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
@@ skipping 72 matching lines @@
     ScriptValue outValue;
     request->show(scope.getScriptState()).then(PaymentResponseFunction::create(scope.getScriptState(), &outValue), funcs.expectNoCall());
 
     static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
 
     v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
     PaymentResponse* pr = V8PaymentResponse::toImplWithTypeCheck(scope.isolate(), outValue.v8Value());
     EXPECT_TRUE(pr->payerPhone().isNull());
 }
 
+// If the merchant does not request a payer name, the resolved show() promise
+// should contain null payer name.
+TEST(OnPaymentResponseTest, NameNotRequired)
+{
+    V8TestingScope scope;
+    PaymentRequestMockFunctionScope funcs(scope.getScriptState());
+    makePaymentRequestOriginSecure(scope.document());
+    PaymentOptions options;
+    options.setRequestPayerName(false);
+    PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
+    EXPECT_FALSE(scope.getExceptionState().hadException());
+    mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
+    response->payer_name = String();
+    ScriptValue outValue;
+    request->show(scope.getScriptState()).then(PaymentResponseFunction::create(scope.getScriptState(), &outValue), funcs.expectNoCall());
+
+    static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
+
+    v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
+    PaymentResponse* pr = V8PaymentResponse::toImplWithTypeCheck(scope.isolate(), outValue.v8Value());
+    EXPECT_TRUE(pr->payerName().isNull());
+}
+
 // If the merchant does not request an email address, the resolved show()
 // promise should contain null email address.
 TEST(OnPaymentResponseTest, EmailNotRequired)
 {
     V8TestingScope scope;
     PaymentRequestMockFunctionScope funcs(scope.getScriptState());
     makePaymentRequestOriginSecure(scope.document());
     PaymentOptions options;
     options.setRequestPayerEmail(false);
     PaymentRequest* request = PaymentRequest::create(scope.getScriptState(), buildPaymentMethodDataForTest(), buildPaymentDetailsForTest(), options, scope.getExceptionState());
     EXPECT_FALSE(scope.getExceptionState().hadException());
     mojom::blink::PaymentResponsePtr response = mojom::blink::PaymentResponse::New();
     response->payer_email = String();
     ScriptValue outValue;
     request->show(scope.getScriptState()).then(PaymentResponseFunction::create(scope.getScriptState(), &outValue), funcs.expectNoCall());
 
     static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(std::move(response));
 
     v8::MicrotasksScope::PerformCheckpoint(scope.isolate());
     PaymentResponse* pr = V8PaymentResponse::toImplWithTypeCheck(scope.isolate(), outValue.v8Value());
     EXPECT_TRUE(pr->payerEmail().isNull());
 }
 
 } // namespace
 } // namespace blink