Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2348093002:
Fix bisect-builds.py crash for non-official win64 builds (Closed)
DescriptionFix bisect-builds.py crash for non-official win64 builds
This patch fixes a bug that bisect-builds.py crashes when attempting to download non-official Win64 builds.
BUG=478255
TEST=python tools\bisect-builds.py -a win64 -g 415582 -b 416585
Committed: https://crrev.com/734efbc9aff1dc000e9e0669e9b287ca6acf506a
Cr-Commit-Position: refs/heads/master@{#420544}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Simplify code #Messages
Total messages: 24 (12 generated)
Description was changed from ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py fails to run when attempting to download non-official Win64 builds. BUG=478255 TEST=python bisect.py -a win64 -g 415582 -b 416585 ========== to ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py fails to run when attempting to download non-official Win64 builds. BUG=478255 TEST=python bisect.py -a win64 -g 415582 -b 416585 ==========
jiawei.shao@intel.com changed reviewers: + jmadill@chromium.org, qiankun.miao@intel.com, stip@chromium.org, yang.gu@intel.com, yunchao.he@intel.com
Description was changed from ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py fails to run when attempting to download non-official Win64 builds. BUG=478255 TEST=python bisect.py -a win64 -g 415582 -b 416585 ========== to ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py fails to run when attempting to download non-official Win64 builds. BUG=478255 TEST=python tools\bisect-builds.py -a win64 -g 415582 -b 416585 ==========
PTAL. Thanks!
qiankun.miao@intel.com changed reviewers: + anantha@chromium.org
LGTM anantha: owner review.
I'm probably not a good reviewer for this.
On 2016/09/19 23:30:17, stip wrote: > I'm probably not a good reviewer for this. I see you at another similar issue that works for Mac64, then I add you here: https://codereview.chromium.org/1407263008 Could you give me some suggestions? Thanks!
jiawei.shao@intel.com changed reviewers: + prasadv@chromium.org, robertocn@chromium.org
Add owner review
qiankun.miao@intel.com changed reviewers: + dpranke@chromium.org - anantha@chromium.org, jmadill@chromium.org, stip@chromium.org
Hi prasadv, RobertoCN, dpranke, can you review this patch? Thanks.
jmadill@chromium.org changed reviewers: + jmadill@chromium.org
seems good but also not an owner. Dirk or Roberto if you could look quickly it would be appreciated, this affects everyone bisecting Chrome on Win64. https://codereview.chromium.org/2348093002/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (right): https://codereview.chromium.org/2348093002/diff/1/tools/bisect-builds.py#newc... tools/bisect-builds.py:158: elif self.platform in ('win', 'win64'): since these only use self._listing_platform_dir, I would probably flatten the nested ifs to the elif level.
lgtm
lgtm with the suggested change.
Description was changed from ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py fails to run when attempting to download non-official Win64 builds. BUG=478255 TEST=python tools\bisect-builds.py -a win64 -g 415582 -b 416585 ========== to ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py crashes when attempting to download non-official Win64 builds. BUG=478255 TEST=python tools\bisect-builds.py -a win64 -g 415582 -b 416585 ==========
The CQ bit was checked by jiawei.shao@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, prasadv@chromium.org, qiankun.miao@intel.com Link to the patchset: https://codereview.chromium.org/2348093002/#ps20001 (title: "Simplify code")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py crashes when attempting to download non-official Win64 builds. BUG=478255 TEST=python tools\bisect-builds.py -a win64 -g 415582 -b 416585 ========== to ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py crashes when attempting to download non-official Win64 builds. BUG=478255 TEST=python tools\bisect-builds.py -a win64 -g 415582 -b 416585 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py crashes when attempting to download non-official Win64 builds. BUG=478255 TEST=python tools\bisect-builds.py -a win64 -g 415582 -b 416585 ========== to ========== Fix bisect-builds.py crash for non-official win64 builds This patch fixes a bug that bisect-builds.py crashes when attempting to download non-official Win64 builds. BUG=478255 TEST=python tools\bisect-builds.py -a win64 -g 415582 -b 416585 Committed: https://crrev.com/734efbc9aff1dc000e9e0669e9b287ca6acf506a Cr-Commit-Position: refs/heads/master@{#420544} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/734efbc9aff1dc000e9e0669e9b287ca6acf506a Cr-Commit-Position: refs/heads/master@{#420544} |
