Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Side by Side Diff: tools/bisect-builds.py

Issue 2348093002: Fix bisect-builds.py crash for non-official win64 builds (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Snapshot Build Bisect Tool 6 """Snapshot Build Bisect Tool
7 7
8 This script bisects a snapshot archive using binary search. It starts at 8 This script bisects a snapshot archive using binary search. It starts at
9 a bad revision (it will try to guess HEAD) and asks for a last known-good 9 a bad revision (it will try to guess HEAD) and asks for a last known-good
10 revision. It will then binary search across this revision range by downloading, 10 revision. It will then binary search across this revision range by downloading,
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 self._listing_platform_dir = 'Linux/' 148 self._listing_platform_dir = 'Linux/'
149 elif self.platform == 'linux64': 149 elif self.platform == 'linux64':
150 self._listing_platform_dir = 'Linux_x64/' 150 self._listing_platform_dir = 'Linux_x64/'
151 elif self.platform == 'linux-arm': 151 elif self.platform == 'linux-arm':
152 self._listing_platform_dir = 'Linux_ARM_Cross-Compile/' 152 self._listing_platform_dir = 'Linux_ARM_Cross-Compile/'
153 elif self.platform == 'chromeos': 153 elif self.platform == 'chromeos':
154 self._listing_platform_dir = 'Linux_ChromiumOS_Full/' 154 self._listing_platform_dir = 'Linux_ChromiumOS_Full/'
155 elif self.platform in ('mac', 'mac64'): 155 elif self.platform in ('mac', 'mac64'):
156 self._listing_platform_dir = 'Mac/' 156 self._listing_platform_dir = 'Mac/'
157 self._binary_name = 'Chromium.app/Contents/MacOS/Chromium' 157 self._binary_name = 'Chromium.app/Contents/MacOS/Chromium'
158 elif self.platform == 'win': 158 elif self.platform in ('win', 'win64'):
Jamie Madill 2016/09/22 13:55:22 since these only use self._listing_platform_dir, I
159 self._listing_platform_dir = 'Win/' 159 if self.platform == 'win':
160 self._listing_platform_dir = 'Win/'
161 elif self.platform == 'win64':
162 self._listing_platform_dir = 'Win_x64/'
160 163
161 def GetASANPlatformDir(self): 164 def GetASANPlatformDir(self):
162 """ASAN builds are in directories like "linux-release", or have filenames 165 """ASAN builds are in directories like "linux-release", or have filenames
163 like "asan-win32-release-277079.zip". This aligns to our platform names 166 like "asan-win32-release-277079.zip". This aligns to our platform names
164 except in the case of Windows where they use "win32" instead of "win".""" 167 except in the case of Windows where they use "win32" instead of "win"."""
165 if self.platform == 'win': 168 if self.platform == 'win':
166 return 'win32' 169 return 'win32'
167 else: 170 else:
168 return self.platform 171 return self.platform
169 172
(...skipping 993 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 if min_blink_rev != max_blink_rev: 1166 if min_blink_rev != max_blink_rev:
1164 print ('NOTE: There is a Blink roll in the range, ' 1167 print ('NOTE: There is a Blink roll in the range, '
1165 'you might also want to do a Blink bisect.') 1168 'you might also want to do a Blink bisect.')
1166 1169
1167 print 'CHANGELOG URL:' 1170 print 'CHANGELOG URL:'
1168 PrintChangeLog(min_chromium_rev, max_chromium_rev) 1171 PrintChangeLog(min_chromium_rev, max_chromium_rev)
1169 1172
1170 1173
1171 if __name__ == '__main__': 1174 if __name__ == '__main__':
1172 sys.exit(main()) 1175 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698