Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1407263008: Fix bisect-builds.py crash for non-official mac64 builds (Closed)

Created:
5 years, 1 month ago by pdr.
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bisect-builds.py crash for non-official mac64 builds There is no mac64 chromium distinction [1,2] and all builds are now 16 whole nibbles. This patch updates bisect-builds.py to use the same codepath for mac64 and mac which has the nice effect of not crashing when --archive=mac64 is used. Since ~m39, all chromium mac builds have been 64bit. TEST= tools/bisect-builds.py --archive=mac64 -g 330000 -b 340000 [1] http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html [2] http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Mac/355973/ BUG=530321 Committed: https://crrev.com/db1d9ecccc0a59264de89067cb1ff354e42faeed Cr-Commit-Position: refs/heads/master@{#356057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/bisect-builds.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
pdr.
This file doesn't really have an owner (tools/OWNERS file says: *). Would either of you ...
5 years, 1 month ago (2015-10-26 01:08:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407263008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407263008/1
5 years, 1 month ago (2015-10-26 03:01:23 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-26 03:10:41 UTC) #6
ghost stip (do not use)
lgtm
5 years, 1 month ago (2015-10-26 06:10:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407263008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407263008/1
5 years, 1 month ago (2015-10-26 16:05:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 16:08:54 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 16:10:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db1d9ecccc0a59264de89067cb1ff354e42faeed
Cr-Commit-Position: refs/heads/master@{#356057}

Powered by Google App Engine
This is Rietveld 408576698