Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2346973003: bot_update: ensure correct depot_tools checkout is used. (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : +expectations. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M recipe_modules/bot_update/api.py View 1 chunk +1 line, -1 line 1 comment Download
M recipe_modules/bot_update/example.expected/basic.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/gerrit_no_rebase_patch_ref.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/gerrit_no_reset.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346973003/1
4 years, 3 months ago (2016-09-16 06:08:00 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-16 06:08:01 UTC) #4
Vadim Sh.
lgtm
4 years, 3 months ago (2016-09-16 06:08:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346973003/20001
4 years, 3 months ago (2016-09-16 06:10:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/972ac5040176acd90c8a1ce412f75d19f77cc4e8
4 years, 3 months ago (2016-09-16 06:13:31 UTC) #10
iannucci
lgtm https://codereview.chromium.org/2346973003/diff/20001/recipe_modules/bot_update/api.py File recipe_modules/bot_update/api.py (right): https://codereview.chromium.org/2346973003/diff/20001/recipe_modules/bot_update/api.py#newcode37 recipe_modules/bot_update/api.py:37: str(self._module.PACKAGE_REPO_ROOT), kwargs['env']['PATH']]) aarrrrggghhhh :'( This explains so much ...
4 years, 3 months ago (2016-09-16 07:25:59 UTC) #12
tandrii(chromium)
4 years, 3 months ago (2016-09-16 07:47:03 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2349673002/ by tandrii@chromium.org.

The reason for reverting is: broke win_chromium_x64_rel_ng/builds/281022
because of apply_issue.bat calls local python..

Powered by Google App Engine
This is Rietveld 408576698