recipe_modules/bot_update/api.py - Issue 2346973003: bot_update: ensure correct depot_tools checkout is used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/bot_update/api.py

Issue 2346973003: bot_update: ensure correct depot_tools checkout is used. (Closed)

Patch Set: +expectations. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: recipe_modules/bot_update/api.py

diff --git a/recipe_modules/bot_update/api.py b/recipe_modules/bot_update/api.py

index f1f31bd1c3458a65b4c62d3d0d11e8f20314cc03..540ba8db35b1bdc4ca4ba0e9092b4b239565f89e 100644

--- a/recipe_modules/bot_update/api.py

+++ b/recipe_modules/bot_update/api.py

@@ -34,7 +34,7 @@ class BotUpdateApi(recipe_api.RecipeApi):

kwargs.setdefault('env', {})

kwargs['env'].setdefault('PATH', '%(PATH)s')

kwargs['env']['PATH'] = self.m.path.pathsep.join([

- kwargs['env']['PATH'], str(self._module.PACKAGE_REPO_ROOT)])

+ str(self._module.PACKAGE_REPO_ROOT), kwargs['env']['PATH']])

iannucci 2016/09/16 07:25:59 aarrrrggghhhh :'( This explains so much :(

return self.m.python(name, bot_update_path, cmd, **kwargs)

@property

« no previous file with comments | « no previous file | recipe_modules/bot_update/example.expected/basic.json » ('j') | no next file with comments »