Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 23469013: Reland "Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class." (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland "Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class." These classes are meant to replace OS::Ticks() and OS::TimeCurrentMillis(), which are broken in several ways. The ElapsedTimer class implements a stopwatch using TimeTicks::HighResNow() for high resolution, monotonic timing. Also fix the CpuProfile::GetStartTime() and CpuProfile::GetEndTime() methods to actually return the time relative to the unix epoch as stated in the documentation (previously that was relative to some arbitrary point in time, i.e. boot time). BUG=v8:2853 R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16398

Patch Set 1 : Make MSVC happy. #

Patch Set 2 : REBASE #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1258 lines, -260 lines) Patch
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.h View 4 chunks +12 lines, -13 lines 0 comments Download
M src/compiler.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M src/counters.h View 2 chunks +3 lines, -6 lines 0 comments Download
M src/counters.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M src/cpu-profiler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/hydrogen.h View 1 chunk +11 lines, -15 lines 0 comments Download
M src/hydrogen.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/log.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M src/optimizing-compiler-thread.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M src/parser.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M src/platform.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 1 1 chunk +1 line, -13 lines 0 comments Download
M src/platform-win32.cc View 1 12 chunks +21 lines, -106 lines 0 comments Download
A src/platform/elapsed-timer.h View 1 chunk +120 lines, -0 lines 0 comments Download
A src/platform/time.h View 1 chunk +381 lines, -0 lines 0 comments Download
A src/platform/time.cc View 1 chunk +482 lines, -0 lines 0 comments Download
M src/profile-generator.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/win32-headers.h View 4 chunks +5 lines, -2 lines 0 comments Download
M src/win32-math.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 5 chunks +9 lines, -11 lines 0 comments Download
A test/cctest/test-time.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 6 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Hey Michael, Fixed Windows build (verified on Jakobs machine). And renamed time folder to platform ...
7 years, 3 months ago (2013-08-28 12:32:02 UTC) #1
Michael Achenbach
On 2013/08/28 12:32:02, Benedikt Meurer wrote: > Hey Michael, > Fixed Windows build (verified on ...
7 years, 3 months ago (2013-08-28 12:54:19 UTC) #2
Benedikt Meurer
Committed patchset #3 manually as r16398 (presubmit successful).
7 years, 3 months ago (2013-08-28 13:03:36 UTC) #3
yurys
7 years, 3 months ago (2013-08-28 13:35:46 UTC) #4
Message was sent while issue was closed.
It seems to break Android Arm compilation:

  LINK(host)
/sources/chrome-git-new/v8_bleeding/out/android_arm.release/mksnapshot.arm
  AR(target)
/sources/chrome-git-new/v8_bleeding/out/android_arm.release/obj.target/tools/gyp/libv8_base.arm.a
/sources/chrome-git-new/v8_bleeding/out/android_arm.release/obj.host/v8_base.arm/src/platform/time.o:
In function `v8::internal::TimeTicks::HighResNow()':
time.cc:(.text._ZN2v88internal9TimeTicks10HighResNowEv+0x18): undefined
reference to `clock_gettime'
collect2: ld returned 1 exit status

Powered by Google App Engine
This is Rietveld 408576698