mac rtl: pin profile switcher to left edge in rtl

mac rtl: pin profile switcher to left edge in rtl

Otherwise, moving the right edge of the window moves the switcher. Oops.

This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to
include a test for base::i18n::IsRTL(), since every callsite needed to check
both.

BUG=642732
Committed: https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4
Cr-Commit-Position: refs/heads/master@{#419155}

[Elly Fong-Jones, 2016-09-15 11:17:05]

Description was changed from

==========
mac rtl: pin profile switcher to left edge in rtl

Otherwise, moving the right edge of the window moves the switcher. Oops.

This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to
include a test for base::i18n::IsRTL(), since every callsite needed to check
both.

BUG=642732
==========

to

==========
mac rtl: pin profile switcher to left edge in rtl

Otherwise, moving the right edge of the window moves the switcher. Oops.

This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to
include a test for base::i18n::IsRTL(), since every callsite needed to check
both.

BUG=642732
==========

[Elly Fong-Jones, 2016-09-15 11:17:06]

ellyjones@chromium.org changed reviewers:
+ mark@chromium.org

[Elly Fong-Jones, 2016-09-15 11:17:13]

mark: ptal? :)

[Mark Mentovai, 2016-09-15 13:46:11]

Good morning, Elly! LGTM.

https://codereview.chromium.org/2346783002/diff/1/chrome/browser/ui/cocoa/l10...
File chrome/browser/ui/cocoa/l10n_util.h (right):

https://codereview.chromium.org/2346783002/diff/1/chrome/browser/ui/cocoa/l10...
chrome/browser/ui/cocoa/l10n_util.h:39: // 2) The browser UI is in RTL mode.
The name of the function doesn’t indicate that it does this, so when you read
the code at the call sites, it looks like this aspect is unchecked. IS there a
better name that you can use for the function?

[Elly Fong-Jones, 2016-09-16 12:56:46]

https://codereview.chromium.org/2346783002/diff/1/chrome/browser/ui/cocoa/l10...
File chrome/browser/ui/cocoa/l10n_util.h (right):

https://codereview.chromium.org/2346783002/diff/1/chrome/browser/ui/cocoa/l10...
chrome/browser/ui/cocoa/l10n_util.h:39: // 2) The browser UI is in RTL mode.
On 2016/09/15 13:46:11, Mark Mentovai wrote:
> The name of the function doesn’t indicate that it does this, so when you read
> the code at the call sites, it looks like this aspect is unchecked. IS there a
> better name that you can use for the function?

Renamed it to ShouldDoExperimentalRTLLayout.

[Elly Fong-Jones, 2016-09-16 12:56:48]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-09-16 12:56:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2346783002/#ps20001
(title: "ExperimentalMacRTLIsEnabled -> ShouldDoExperimentalRTLLayout")

[commit-bot: I haz the power, 2016-09-16 12:57:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 13:35:34]

Description was changed from

==========
mac rtl: pin profile switcher to left edge in rtl

Otherwise, moving the right edge of the window moves the switcher. Oops.

This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to
include a test for base::i18n::IsRTL(), since every callsite needed to check
both.

BUG=642732
==========

to

==========
mac rtl: pin profile switcher to left edge in rtl

Otherwise, moving the right edge of the window moves the switcher. Oops.

This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to
include a test for base::i18n::IsRTL(), since every callsite needed to check
both.

BUG=642732
==========

[commit-bot: I haz the power, 2016-09-16 13:35:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 13:37:52]

Description was changed from

==========
mac rtl: pin profile switcher to left edge in rtl

Otherwise, moving the right edge of the window moves the switcher. Oops.

This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to
include a test for base::i18n::IsRTL(), since every callsite needed to check
both.

BUG=642732
==========

to

==========
mac rtl: pin profile switcher to left edge in rtl

Otherwise, moving the right edge of the window moves the switcher. Oops.

This CL also refactors cocoa_l10n_util::ExperimentalMacRTLIsEnabled() to
include a test for base::i18n::IsRTL(), since every callsite needed to check
both.

BUG=642732

Committed: https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4
Cr-Commit-Position: refs/heads/master@{#419155}
==========

[commit-bot: I haz the power, 2016-09-16 13:37:53]

Patchset 2 (id:??) landed as
https://crrev.com/e5804676b8bbf0fdd6d68cb0b6b97da0046180b4
Cr-Commit-Position: refs/heads/master@{#419155}