Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/browser/ui/cocoa/l10n_util.mm

Issue 2346783002: mac rtl: pin profile switcher to left edge in rtl (Closed)
Patch Set: ExperimentalMacRTLIsEnabled -> ShouldDoExperimentalRTLLayout Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/l10n_util.h ('k') | chrome/browser/ui/cocoa/new_tab_button.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/l10n_util.mm
diff --git a/chrome/browser/ui/cocoa/l10n_util.mm b/chrome/browser/ui/cocoa/l10n_util.mm
index 5f101279c971a1a72d392d0d5bb0fbb892323a89..b6dee1e0b967c7fee50e13b3a212af59af2cc102 100644
--- a/chrome/browser/ui/cocoa/l10n_util.mm
+++ b/chrome/browser/ui/cocoa/l10n_util.mm
@@ -5,6 +5,7 @@
#import "chrome/browser/ui/cocoa/l10n_util.h"
#include "base/feature_list.h"
+#include "base/i18n/rtl.h"
#include "base/strings/string_util.h"
#include "base/strings/sys_string_conversions.h"
#import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"
@@ -86,8 +87,9 @@ CGFloat VerticallyReflowGroup(NSArray* views) {
const base::Feature kExperimentalMacRTL{"ExperimentalMacRTL",
base::FEATURE_DISABLED_BY_DEFAULT};
-bool ExperimentalMacRTLIsEnabled() {
- return base::FeatureList::IsEnabled(kExperimentalMacRTL);
+bool ShouldDoExperimentalRTLLayout() {
+ return base::i18n::IsRTL() &&
+ base::FeatureList::IsEnabled(kExperimentalMacRTL);
}
} // namespace cocoa_l10n_util
« no previous file with comments | « chrome/browser/ui/cocoa/l10n_util.h ('k') | chrome/browser/ui/cocoa/new_tab_button.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698