chrome/browser/ui/cocoa/framed_browser_window.mm - Issue 2346783002: mac rtl: pin profile switcher to left edge in rtl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/framed_browser_window.mm

Issue 2346783002: mac rtl: pin profile switcher to left edge in rtl (Closed)

Patch Set: ExperimentalMacRTLIsEnabled -> ShouldDoExperimentalRTLLayout Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/framed_browser_window.mm

diff --git a/chrome/browser/ui/cocoa/framed_browser_window.mm b/chrome/browser/ui/cocoa/framed_browser_window.mm

index 416b98719e160e9f283ce93271793d2557caa512..ca5f0186aa231d6555ebe30703db6efc6463959f 100644

--- a/chrome/browser/ui/cocoa/framed_browser_window.mm

+++ b/chrome/browser/ui/cocoa/framed_browser_window.mm

@@ -6,7 +6,6 @@

#include <stddef.h>

-#include "base/i18n/rtl.h"

#include "base/logging.h"

#include "base/mac/sdk_forward_declarations.h"

#include "chrome/browser/global_keyboard_shortcuts_mac.h"

@@ -162,7 +161,7 @@ - (void)adjustButton:(NSButton*)button

break;

}

- if (cocoa_l10n_util::ExperimentalMacRTLIsEnabled() && base::i18n::IsRTL()) {

+ if (cocoa_l10n_util::ShouldDoExperimentalRTLLayout()) {

buttonFrame.origin.x =

NSWidth([self frame]) - buttonFrame.origin.x - NSWidth([button frame]);

}