Issue 234583004: Fix a crash caused by calling detached navigator APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234583004: Fix a crash caused by calling detached navigator APIs. (Closed)

Created:
6 years, 8 months ago by yhirano

Modified:
6 years, 8 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, gyuyoung.kim_webkit.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix a crash caused by calling detached navigator APIs. Calling a navigator method leads to a crash when: - The navigator is associated with an iframe, - The iframe has some contents and - The iframe is detached. This CL fixes the crash. BUG=358800 R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171451

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -1 line)			Patch
A	LayoutTests/fast/dom/navigator-with-content-detached-no-crash.html	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/navigator-with-content-detached-no-crash-expected.txt	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/modules/webmidi/NavigatorWebMIDI.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/234583004/20001

6 years, 8 months ago (2014-04-11 18:36:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/234583004/20001

6 years, 8 months ago (2014-04-14 06:23:32 UTC) #6

Message was sent while issue was closed.

Change committed as 171451

Expand Messages | Collapse Messages