Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp - Issue 234583004: Fix a crash caused by calling detached navigator APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

Issue 234583004: Fix a crash caused by calling detached navigator APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/navigator-with-content-detached-no-crash-expected.txt ('k') | Source/modules/webmidi/NavigatorWebMIDI.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

diff --git a/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp b/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

index a0ca52fcf60dde5adaeec65d352a0b7e2d28c486..c481505892e9f57e019a65925ed84e7a8206d3e1 100644

--- a/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

+++ b/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

@@ -181,6 +181,9 @@ String NavigatorContentUtils::isProtocolHandlerRegistered(Navigator& navigator,

return declined;

Document* document = navigator.frame()->document();

+ if (document->activeDOMObjectsAreStopped())

+ return declined;

KURL baseURL = document->baseURL();

if (!verifyCustomHandlerURL(baseURL, url, exceptionState))