Source/modules/webmidi/NavigatorWebMIDI.cpp - Issue 234583004: Fix a crash caused by calling detached navigator APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/NavigatorWebMIDI.cpp

Issue 234583004: Fix a crash caused by calling detached navigator APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/NavigatorWebMIDI.cpp

diff --git a/Source/modules/webmidi/NavigatorWebMIDI.cpp b/Source/modules/webmidi/NavigatorWebMIDI.cpp

index 278986bea50a555b2da94945df82376a028aea27..12aece2598e3168e590fa483fac58ce3c0983955 100644

--- a/Source/modules/webmidi/NavigatorWebMIDI.cpp

+++ b/Source/modules/webmidi/NavigatorWebMIDI.cpp

@@ -73,7 +73,7 @@ ScriptPromise NavigatorWebMIDI::requestMIDIAccess(Navigator& navigator, const Di

ScriptPromise NavigatorWebMIDI::requestMIDIAccess(const Dictionary& options)

{

- if (!frame()) {

+ if (!frame() || frame()->document()->activeDOMObjectsAreStopped()) {

RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(v8::Isolate::GetCurrent());

ScriptPromise promise = resolver->promise();

// FIXME: Currently this rejection does not work because the context is stopped.

« no previous file with comments | « Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp ('k') | no next file » | no next file with comments »