Source/web/tests/GraphicsLayerTest.cpp - Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/GraphicsLayerTest.cpp

Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve WebPassOwnPtr so that it is hard to make a mistake. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/GraphicsLayerTest.cpp

diff --git a/Source/web/tests/GraphicsLayerTest.cpp b/Source/web/tests/GraphicsLayerTest.cpp

index 3f9d624b01322297c37c3059074a2bbcd0a19728..cb322d7bbe8ed750f4b51a80aa2b7fc0cb12c565 100644

--- a/Source/web/tests/GraphicsLayerTest.cpp

+++ b/Source/web/tests/GraphicsLayerTest.cpp

@@ -94,7 +94,7 @@ TEST_F(GraphicsLayerTest, updateLayerPreserves3DWithAnimations)

curve->add(WebFloatKeyframe(0.0, 0.0));

OwnPtr<WebAnimation> floatAnimation(adoptPtr(Platform::current()->compositorSupport()->createAnimation(*curve, WebAnimation::TargetPropertyOpacity)));

int animationId = floatAnimation->id();

- ASSERT_TRUE(m_platformLayer->addAnimation(floatAnimation.get()));

+ ASSERT_TRUE(m_platformLayer->addAnimation(floatAnimation.release()));

ASSERT_TRUE(m_platformLayer->hasActiveAnimation());

« no previous file with comments | « Source/web/LinkHighlight.cpp ('k') | public/platform/WebLayer.h » ('j') | no next file with comments »