Source/web/LinkHighlight.cpp - Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/LinkHighlight.cpp

Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve WebPassOwnPtr so that it is hard to make a mistake. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/LinkHighlight.cpp

diff --git a/Source/web/LinkHighlight.cpp b/Source/web/LinkHighlight.cpp

index e7427792b556396dcf1aa15a934efc15c19b28c8..43a5893de03078c9d895282d227a0f0bf1bf42f2 100644

--- a/Source/web/LinkHighlight.cpp

+++ b/Source/web/LinkHighlight.cpp

@@ -272,10 +272,10 @@ void LinkHighlight::startHighlightAnimationIfNeeded()

// For layout tests we don't fade out.

curve->add(WebFloatKeyframe(fadeDuration + extraDurationRequired, WebKit::layoutTestMode() ? startOpacity : 0));

- m_animation = adoptPtr(compositorSupport->createAnimation(*curve, WebAnimation::TargetPropertyOpacity));

+ OwnPtr<WebAnimation> animation = adoptPtr(compositorSupport->createAnimation(*curve, WebAnimation::TargetPropertyOpacity));

m_contentLayer->layer()->setDrawsContent(true);

- m_contentLayer->layer()->addAnimation(m_animation.get());

+ m_contentLayer->layer()->addAnimation(animation.release());

invalidate();

m_owningWebViewImpl->scheduleAnimation();

« no previous file with comments | « Source/web/LinkHighlight.h ('k') | Source/web/tests/GraphicsLayerTest.cpp » ('j') | no next file with comments »