public/platform/WebLayer.h - Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebLayer.h

Issue 23455058: WIP: WebLayer::addAnimation should transfer the ownership of WebAnimation instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve WebPassOwnPtr so that it is hard to make a mistake. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebLayer.h

diff --git a/public/platform/WebLayer.h b/public/platform/WebLayer.h

index 67312e0a736324d3ac7fec063647e0efee99d8b1..6721e4948900bb59ba84cfa253af862c1325464b 100644

--- a/public/platform/WebLayer.h

+++ b/public/platform/WebLayer.h

@@ -30,6 +30,7 @@

#include "WebColor.h"

#include "WebCommon.h"

#include "WebCompositingReasons.h"

+#include "WebPassOwnPtr.h"

#include "WebPoint.h"

#include "WebRect.h"

#include "WebString.h"

@@ -137,7 +138,7 @@ public:

virtual void setAnimationDelegate(WebAnimationDelegate*) = 0;

// Returns false if the animation cannot be added.

- virtual bool addAnimation(WebAnimation*) = 0;

+ virtual bool addAnimation(WebPassOwnPtr<WebAnimation>) = 0;

// Removes all animations with the given id.

virtual void removeAnimation(int animationId) = 0;

« no previous file with comments | « Source/web/tests/GraphicsLayerTest.cpp ('k') | public/platform/WebPassOwnPtr.h » ('j') | no next file with comments »