dart2js: run dartfmt on tests

dart2js: run dartfmt on tests

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/3d31aa2ff789508202491e7b5a2bdc105c315a37

[Harry Terkelsen, 2016-09-16 19:25:59]

het@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-09-16 20:55:24]

thanks Harry!

Overall looks great! Just a few places where we need to revert the changes to
preserve the support for multi-part tests. Other than that, I just have a few
random rants :)

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_p...
File tests/compiler/dart2js/js_parser_statements_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_p...
tests/compiler/dart2js/js_parser_statements_test.dart:200: [eOne]
this and a few other changes in this file are quite sad :(

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
File tests/compiler/dart2js/js_spec_optimization_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
tests/compiler/dart2js/js_spec_optimization_test.dart:89: asyncTest(() =>
Future.wait([check(TEST_1), check(TEST_2), check(TEST_3),]));
may want to delete trailing ,

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
File tests/compiler/dart2js/js_spec_string_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
tests/compiler/dart2js/js_spec_string_test.dart:56: setSideEffects: (effects) {
:( - maybe use => notation instead?

setThrows: (b) => actualThrows = b,

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/sema...
File tests/compiler/dart2js/semantic_visitor_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/sema...
tests/compiler/dart2js/semantic_visitor_test.dart:393: VISIT_LOCAL_VARIABLE_GET,
probably not worth it, but we could add some // comments to create the groups
like they were

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/sha1...
File tests/compiler/dart2js/sha1_short_test_vectors.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/sha1...
tests/compiler/dart2js/sha1_short_test_vectors.dart:11: const [],
not sure if it's worth formatting this one, maybe revert?

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/simp...
File tests/compiler/dart2js/simple_inferrer_const_closure_default_test.dart
(right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/simp...
tests/compiler/dart2js/simple_inferrer_const_closure_default_test.dart:71: ///
01: ok
revert => this changes the semantics of the multi-test framework :-/

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/basic_class_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/basic_class_test.dart:19: /// 01: static type
warning
revert

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/big_allocation_expression_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/big_allocation_expression_test.dart:1290: new A(new
A(new A(new A(new A(new A(new A(null, null), new A(null, null)), new A(new
A(null, null), new A(null, null))), new A(new A(new A(null, null), new A(null,
null)), new A(new A(null, null), new A(null, null)))), new A(new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null, null))),
new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null))))), new A(new A(new A(new A(new A(null, null), new A(null,
null)), new A(new A(null, null), new A(null, null))), new A(new A(new A(null,
null), new A(null, null)), new A(new A(null, null), new A(null, null)))), new
A(new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null),
new A(null, null))), new A(new A(new A(null, null), new A(null, null)), new
A(new A(null, null), new A(null, null)))))), new A(new A(new A(new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null, null))),
new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null)))), new A(new A(new A(new A(null, null), new A(null, null)), new
A(new A(null, null), new A(null, null))), new A(new A(new A(null, null), new
A(null, null)), new A(new A(null, null), new A(null, null))))), new A(new A(new
A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null))), new A(new A(new A(null, null), new A(null, null)), new A(new
A(null, null), new A(null, null)))), new A(new A(new A(new A(null, null), new
A(null, null)), new A(new A(null, null), new A(null, null))), new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null,
null)))))))),
wow! --- did we pass the limit of what the formatter can do?

revert?

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/bounds_check_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/bounds_check_test.dart:9: /// 01: runtime error
revert here too

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/compile_time_constant4_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/compile_time_constant4_test.dart:12: /// 01:
compile-time error
ditto (revert)

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/empty_negative_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/empty_negative_test.dart:1: 
revert? (not sure it matters, but this file would no longer be "empty")

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/for_in_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/for_in_test.dart:61: ["a"]
so sad... so sad... maybe file a bug on dartfmt?

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/int_index_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/int_index_test.dart:9: /// 01: runtime error
revert

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/minus_zero_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/minus_zero_test.dart:11: /// 01: static type
warning, checked mode compile-time error
revert

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/operator2_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/operator2_test.dart:7: int zero() {
sigh :(, I guess we could've used "=>"... you can keep as it is, just ranting
here

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/private_symbol_literal_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/private_symbol_literal_test.dart:14: /// 01:
compile-time error
revert

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/regress/4562_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/regress/4562_test.dart:9: /// 01: compile-time
error
revert

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/throw1_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/throw1_test.dart:8: /// 01: runtime error
revert

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/throw2_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/throw2_test.dart:36: /// 01: runtime error
ditto

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/type_constant_switch_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/type_constant_switch_test.dart:17: /// 01:
compile-time error
ditto

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/variable_type_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/variable_type_test.dart:8: /// 01: static type
warning
revert as well

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_nati...
File tests/compiler/dart2js_native/event_loop_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_nati...
tests/compiler/dart2js_native/event_loop_test.dart:14: foo(Callback0 f) native ;
mmm....maybe worth filing a bug on this one too

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_nati...
File tests/compiler/dart2js_native/foreign_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_nati...
tests/compiler/dart2js_native/foreign_test.dart:25: return JS("num", r"# + # + #
+ # + # + # + # + # + # + # + #", a1, a2, a3, a4,
I might prefer the old way here... tentative revert :)?

[Bob Nystrom, 2016-09-16 21:15:59]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2016-09-16 21:16:03]

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_p...
File tests/compiler/dart2js/js_parser_statements_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_p...
tests/compiler/dart2js/js_parser_statements_test.dart:200: [eOne]
On 2016/09/16 20:55:22, Siggi Cherem (dart-lang) wrote:
> this and a few other changes in this file are quite sad :(

dartfmt has a rule that an outer collection always splits if it contains a child
collection. That tends to improve most code where it's good to highlight the
nested structure, but it's not always great in tests that have tiny nested blobs
of collections. :-/

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
File tests/compiler/dart2js/js_spec_optimization_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
tests/compiler/dart2js/js_spec_optimization_test.dart:89: asyncTest(() =>
Future.wait([check(TEST_1), check(TEST_2), check(TEST_3),]));
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> may want to delete trailing ,

This looks like you aren't running the latest dartfmt. As of 0.2.7, a list
literal will always split if it has a trailing comma.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/big_allocation_expression_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/big_allocation_expression_test.dart:1290: new A(new
A(new A(new A(new A(new A(new A(null, null), new A(null, null)), new A(new
A(null, null), new A(null, null))), new A(new A(new A(null, null), new A(null,
null)), new A(new A(null, null), new A(null, null)))), new A(new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null, null))),
new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null))))), new A(new A(new A(new A(new A(null, null), new A(null,
null)), new A(new A(null, null), new A(null, null))), new A(new A(new A(null,
null), new A(null, null)), new A(new A(null, null), new A(null, null)))), new
A(new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null),
new A(null, null))), new A(new A(new A(null, null), new A(null, null)), new
A(new A(null, null), new A(null, null)))))), new A(new A(new A(new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null, null))),
new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null)))), new A(new A(new A(new A(null, null), new A(null, null)), new
A(new A(null, null), new A(null, null))), new A(new A(new A(null, null), new
A(null, null)), new A(new A(null, null), new A(null, null))))), new A(new A(new
A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null))), new A(new A(new A(null, null), new A(null, null)), new A(new
A(null, null), new A(null, null)))), new A(new A(new A(new A(null, null), new
A(null, null)), new A(new A(null, null), new A(null, null))), new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null,
null)))))))),
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> wow! --- did we pass the limit of what the formatter can do?

Yup: https://github.com/dart-lang/dart_style/issues/456

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/for_in_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/for_in_test.dart:61: ["a"]
On 2016/09/16 20:55:24, Siggi Cherem (dart-lang) wrote:
> so sad... so sad... maybe file a bug on dartfmt?

dartfmt just isn't tuned for unusual code like this. It's hard to make weird
code like language tests look nicer without making real-world code look worse.

[Harry Terkelsen, 2016-09-16 21:44:05]

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_p...
File tests/compiler/dart2js/js_parser_statements_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_p...
tests/compiler/dart2js/js_parser_statements_test.dart:200: [eOne]
On 2016/09/16 20:55:22, Siggi Cherem (dart-lang) wrote:
> this and a few other changes in this file are quite sad :(

Acknowledged.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
File tests/compiler/dart2js/js_spec_optimization_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
tests/compiler/dart2js/js_spec_optimization_test.dart:89: asyncTest(() =>
Future.wait([check(TEST_1), check(TEST_2), check(TEST_3),]));
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> may want to delete trailing ,

I thought the trailing ',' was supposed to cause dartfmt to prefer doing
one-per-line. Maybe that's just for argument lists?

I'll delete the trailing comma since it's all on one line now

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
tests/compiler/dart2js/js_spec_optimization_test.dart:89: asyncTest(() =>
Future.wait([check(TEST_1), check(TEST_2), check(TEST_3),]));
On 2016/09/16 21:16:03, Bob Nystrom wrote:
> On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> > may want to delete trailing ,
> 
> This looks like you aren't running the latest dartfmt. As of 0.2.7, a list
> literal will always split if it has a trailing comma.

Oops, I was running 0.2.4.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
File tests/compiler/dart2js/js_spec_string_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
tests/compiler/dart2js/js_spec_string_test.dart:56: setSideEffects: (effects) {
On 2016/09/16 20:55:24, Siggi Cherem (dart-lang) wrote:
> :( - maybe use => notation instead?
> 
> setThrows: (b) => actualThrows = b,

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/sema...
File tests/compiler/dart2js/semantic_visitor_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/sema...
tests/compiler/dart2js/semantic_visitor_test.dart:393: VISIT_LOCAL_VARIABLE_GET,
On 2016/09/16 20:55:24, Siggi Cherem (dart-lang) wrote:
> probably not worth it, but we could add some // comments to create the groups
> like they were

I don't think the groupings are adding much value

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/sha1...
File tests/compiler/dart2js/sha1_short_test_vectors.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/sha1...
tests/compiler/dart2js/sha1_short_test_vectors.dart:11: const [],
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> not sure if it's worth formatting this one, maybe revert?

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/simp...
File tests/compiler/dart2js/simple_inferrer_const_closure_default_test.dart
(right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/simp...
tests/compiler/dart2js/simple_inferrer_const_closure_default_test.dart:71: ///
01: ok
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> revert => this changes the semantics of the multi-test framework :-/

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/basic_class_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/basic_class_test.dart:19: /// 01: static type
warning
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> revert

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/big_allocation_expression_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/big_allocation_expression_test.dart:1290: new A(new
A(new A(new A(new A(new A(new A(null, null), new A(null, null)), new A(new
A(null, null), new A(null, null))), new A(new A(new A(null, null), new A(null,
null)), new A(new A(null, null), new A(null, null)))), new A(new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null, null))),
new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null))))), new A(new A(new A(new A(new A(null, null), new A(null,
null)), new A(new A(null, null), new A(null, null))), new A(new A(new A(null,
null), new A(null, null)), new A(new A(null, null), new A(null, null)))), new
A(new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null),
new A(null, null))), new A(new A(new A(null, null), new A(null, null)), new
A(new A(null, null), new A(null, null)))))), new A(new A(new A(new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null, null))),
new A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null)))), new A(new A(new A(new A(null, null), new A(null, null)), new
A(new A(null, null), new A(null, null))), new A(new A(new A(null, null), new
A(null, null)), new A(new A(null, null), new A(null, null))))), new A(new A(new
A(new A(new A(null, null), new A(null, null)), new A(new A(null, null), new
A(null, null))), new A(new A(new A(null, null), new A(null, null)), new A(new
A(null, null), new A(null, null)))), new A(new A(new A(new A(null, null), new
A(null, null)), new A(new A(null, null), new A(null, null))), new A(new A(new
A(null, null), new A(null, null)), new A(new A(null, null), new A(null,
null)))))))),
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> wow! --- did we pass the limit of what the formatter can do?
> 
> revert?

haha yeah, looks like it gave up. I'll revert

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/bounds_check_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/bounds_check_test.dart:9: /// 01: runtime error
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> revert here too

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/compile_time_constant4_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/compile_time_constant4_test.dart:12: /// 01:
compile-time error
On 2016/09/16 20:55:22, Siggi Cherem (dart-lang) wrote:
> ditto (revert)

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/empty_negative_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/empty_negative_test.dart:1: 
On 2016/09/16 20:55:22, Siggi Cherem (dart-lang) wrote:
> revert? (not sure it matters, but this file would no longer be "empty")

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/for_in_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/for_in_test.dart:61: ["a"]
On 2016/09/16 20:55:24, Siggi Cherem (dart-lang) wrote:
> so sad... so sad... maybe file a bug on dartfmt?

A similar bug exists: https://github.com/dart-lang/dart_style/issues/501

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/int_index_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/int_index_test.dart:9: /// 01: runtime error
On 2016/09/16 20:55:24, Siggi Cherem (dart-lang) wrote:
> revert

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/minus_zero_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/minus_zero_test.dart:11: /// 01: static type
warning, checked mode compile-time error
On 2016/09/16 20:55:22, Siggi Cherem (dart-lang) wrote:
> revert

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/operator2_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/operator2_test.dart:7: int zero() {
On 2016/09/16 20:55:24, Siggi Cherem (dart-lang) wrote:
> sigh :(, I guess we could've used "=>"... you can keep as it is, just ranting
> here

Acknowledged.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/private_symbol_literal_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/private_symbol_literal_test.dart:14: /// 01:
compile-time error
On 2016/09/16 20:55:22, Siggi Cherem (dart-lang) wrote:
> revert

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/regress/4562_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/regress/4562_test.dart:9: /// 01: compile-time
error
On 2016/09/16 20:55:22, Siggi Cherem (dart-lang) wrote:
> revert

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/throw1_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/throw1_test.dart:8: /// 01: runtime error
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> revert

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/throw2_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/throw2_test.dart:36: /// 01: runtime error
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/type_constant_switch_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/type_constant_switch_test.dart:17: /// 01:
compile-time error
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/variable_type_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/variable_type_test.dart:8: /// 01: static type
warning
On 2016/09/16 20:55:24, Siggi Cherem (dart-lang) wrote:
> revert as well

Done.

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_nati...
File tests/compiler/dart2js_native/event_loop_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_nati...
tests/compiler/dart2js_native/event_loop_test.dart:14: foo(Callback0 f) native ;
On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> mmm....maybe worth filing a bug on this one too

Done: https://github.com/dart-lang/dart_style/issues/541

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_nati...
File tests/compiler/dart2js_native/foreign_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js_nati...
tests/compiler/dart2js_native/foreign_test.dart:25: return JS("num", r"# + # + #
+ # + # + # + # + # + # + # + #", a1, a2, a3, a4,
On 2016/09/16 20:55:24, Siggi Cherem (dart-lang) wrote:
> I might prefer the old way here... tentative revert :)?

I prefer the old way too, reverted

[Harry Terkelsen, 2016-09-16 21:50:29]

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
File tests/compiler/dart2js/js_spec_optimization_test.dart (right):

https://codereview.chromium.org/2345083003/diff/1/tests/compiler/dart2js/js_s...
tests/compiler/dart2js/js_spec_optimization_test.dart:89: asyncTest(() =>
Future.wait([check(TEST_1), check(TEST_2), check(TEST_3),]));
On 2016/09/16 21:44:04, Harry Terkelsen wrote:
> On 2016/09/16 21:16:03, Bob Nystrom wrote:
> > On 2016/09/16 20:55:23, Siggi Cherem (dart-lang) wrote:
> > > may want to delete trailing ,
> > 
> > This looks like you aren't running the latest dartfmt. As of 0.2.7, a list
> > literal will always split if it has a trailing comma.
> 
> Oops, I was running 0.2.4.

I added the comma back, and it went one-per-line again

[Siggi Cherem (dart-lang), 2016-09-16 21:52:34]

lgtm, thanks Harry!

[Harry Terkelsen, 2016-09-16 22:49:28]

Description was changed from

==========
dart2js: run dartfmt on tests
==========

to

==========
dart2js: run dartfmt on tests

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3d31aa2ff789508202491e7b5a2bdc105c315a37
==========

[Harry Terkelsen, 2016-09-16 22:49:31]

Committed patchset #5 (id:40001) manually as
3d31aa2ff789508202491e7b5a2bdc105c315a37 (presubmit successful).