Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 import "package:expect/expect.dart"; | 5 import "package:expect/expect.dart"; |
| 6 import 'dart:_foreign_helper' show JS; | 6 import 'dart:_foreign_helper' show JS; |
| 7 | 7 |
| 8 foreign1(var a, var b) { | 8 foreign1(var a, var b) { |
| 9 return JS("num", r"# + #", a, b); | 9 return JS("num", r"# + #", a, b); |
| 10 } | 10 } |
| 11 | 11 |
| 12 var called = false; | 12 var called = false; |
| 13 callOnce() { | 13 callOnce() { |
| 14 Expect.isFalse(called); | 14 Expect.isFalse(called); |
| 15 called = true; | 15 called = true; |
| 16 return 499; | 16 return 499; |
| 17 } | 17 } |
| 18 | 18 |
| 19 foreign2() { | 19 foreign2() { |
| 20 var t = callOnce(); | 20 var t = callOnce(); |
| 21 return JS("num", r"# + #", t, t); | 21 return JS("num", r"# + #", t, t); |
| 22 } | 22 } |
| 23 | 23 |
| 24 foreign11(a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, a11) { | 24 foreign11(a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, a11) { |
| 25 return JS("num", r"# + # + # + # + # + # + # + # + # + # + #", | 25 return JS("num", r"# + # + # + # + # + # + # + # + # + # + #", a1, a2, a3, a4, |
|
Siggi Cherem (dart-lang)
2016/09/16 20:55:24
I might prefer the old way here... tentative rever
Harry Terkelsen
2016/09/16 21:44:04
I prefer the old way too, reverted
| |
| 26 a1, a2, a3, a4, a5, a6, a7, a8, a9, a10, a11); | 26 a5, a6, a7, a8, a9, a10, a11); |
| 27 } | 27 } |
| 28 | 28 |
| 29 void main() { | 29 void main() { |
| 30 Expect.equals(9, foreign1(4, 5)); | 30 Expect.equals(9, foreign1(4, 5)); |
| 31 Expect.equals(998, foreign2()); | 31 Expect.equals(998, foreign2()); |
| 32 Expect.equals('1234567891011', | 32 Expect.equals('1234567891011', |
| 33 foreign11('1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11')); | 33 foreign11('1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11')); |
| 34 // Ensure there will be isNaN and NaN variable names. | 34 // Ensure there will be isNaN and NaN variable names. |
| 35 var isNaN = called ? 42 : 44; | 35 var isNaN = called ? 42 : 44; |
| 36 var NaN = called ? 52 : 54; | 36 var NaN = called ? 52 : 54; |
| 37 Expect.isFalse(JS('bool', 'isNaN(#)', isNaN)); | 37 Expect.isFalse(JS('bool', 'isNaN(#)', isNaN)); |
| 38 Expect.isFalse(JS('bool', 'isNaN(#)', NaN)); | 38 Expect.isFalse(JS('bool', 'isNaN(#)', NaN)); |
| 39 Expect.isTrue(JS('bool', 'isNaN(#)', double.NAN)); | 39 Expect.isTrue(JS('bool', 'isNaN(#)', double.NAN)); |
| 40 } | 40 } |
| OLD | NEW |