Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: tests/compiler/dart2js_extra/code_motion_exception_test.dart

Issue 2345083003: dart2js: run dartfmt on tests (Closed)
Patch Set: revert another multipart test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js_extra/code_motion_exception_test.dart
diff --git a/tests/compiler/dart2js_extra/code_motion_exception_test.dart b/tests/compiler/dart2js_extra/code_motion_exception_test.dart
index 529f3a7c7626b69160c847b2b0d8865d8ca2bcee..95ed39545d92cc12f18e06f10853108753d15ce0 100644
--- a/tests/compiler/dart2js_extra/code_motion_exception_test.dart
+++ b/tests/compiler/dart2js_extra/code_motion_exception_test.dart
@@ -12,8 +12,8 @@ get always => new DateTime.now().millisecondsSinceEpoch > 42;
// gA and gB have type [null|num], so they compile to a receiver check, and
// argument check and then the operation.
-var gA; // [null|num]
-var gB; // [null|num]
+var gA; // [null|num]
+var gB; // [null|num]
foo1(a, b) {
// The checks on a and b are not equivalent, so can't be merged.
@@ -24,7 +24,9 @@ foo1(a, b) {
}
}
-call1() { return foo1(gA, gB); }
+call1() {
+ return foo1(gA, gB);
+}
test1() {
gA = 1;
@@ -41,10 +43,9 @@ test1() {
gA = null;
gB = 2;
- Expect.throws(call1, (e) => e is ArgumentError, 'foo1($gA, $gB) AE');
+ Expect.throws(call1, (e) => e is ArgumentError, 'foo1($gA, $gB) AE');
}
-
foo2a(a, b) {
// The common receiver check on [a] cannot be merged because the operation
// (selector) is different.
@@ -66,14 +67,19 @@ foo2b(a, b) {
}
}
-call2a() { return foo2a(gA, gB); }
-call2b() { return foo2b(gA, gB); }
+call2a() {
+ return foo2a(gA, gB);
+}
+
+call2b() {
+ return foo2b(gA, gB);
+}
checkNSME(text) {
return (e) {
Expect.isTrue(e is NoSuchMethodError,
'expecting NoSuchMethodError, got "${e.runtimeType}"');
- Expect.isTrue('$e'.contains(text), '"$e".contains("$text")');
+ Expect.isTrue('$e'.contains(text), '"$e".contains("$text")');
return e is NoSuchMethodError;
};
}
@@ -96,8 +102,8 @@ test2() {
gA = null;
gB = 2;
- Expect.throws(call2a, checkNSME(r'$and'), 'foo2($gA, $gB) NSME');
- Expect.throws(call2b, checkNSME(r'$xor'), 'foo2($gA, $gB) NSME');
+ Expect.throws(call2a, checkNSME(r'$and'), 'foo2($gA, $gB) NSME');
+ Expect.throws(call2b, checkNSME(r'$xor'), 'foo2($gA, $gB) NSME');
}
main() {

Powered by Google App Engine
This is Rietveld 408576698