Use string pools in some dictionaries

core/fpdfapi/fpdf_parser/include/cpdf_document.h

Index: core/fpdfapi/fpdf_parser/include/cpdf_document.h
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_document.h b/core/fpdfapi/fpdf_parser/include/cpdf_document.h
index 494868ef135ce1e2759b47d7a6a0930f2b23c806..f181edfc19b1d3561a94bdfb331ff3b42dd55e03 100644
--- a/core/fpdfapi/fpdf_parser/include/cpdf_document.h
+++ b/core/fpdfapi/fpdf_parser/include/cpdf_document.h
@@ -12,6 +12,7 @@
 #include "core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"
 #include "core/fpdfdoc/include/cpdf_linklist.h"
+#include "core/fxcrt/include/cfx_string_pool_template.h"
 #include "core/fxcrt/include/fx_basic.h"
 
 class CFX_Font;
@@ -38,7 +39,8 @@ class JBig2_DocumentContext;
 #define FPDFPERM_PRINT_HIGH 0x0800
 #define FPDF_PAGE_MAX_NUM 0xFFFFF
 
-class CPDF_Document : public CPDF_IndirectObjectHolder {
+class CPDF_Document : public CPDF_IndirectObjectHolder,
+                      public CFX_ByteStringPool {

[dsinclair, 2016/09/19 13:24:34]

I'm not sure about this, should the document just contain the pool instead of
being the pool?

Having more things point to document is going to make the system more confusing,
where as having them point to a pool that the document owns seems a little less
tangled?

[Tom Sepez, 2016/09/19 18:24:59]

Done.

  public:
   explicit CPDF_Document(std::unique_ptr<CPDF_Parser> pParser);
   ~CPDF_Document() override;