Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/fpdfdoc/cpdf_annotlist.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)
Patch Set: Remove default ctor Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fpdfapi/fpdf_parser/include/cpdf_document.h ('K') | « core/fpdfapi/fpdf_parser/include/cpdf_document.h ('k') | core/fpdfdoc/cpdf_filespec.cpp » ('j') | core/fpdfdoc/include/cpdf_filespec.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfdoc/cpdf_annotlist.cpp
diff --git a/core/fpdfdoc/cpdf_annotlist.cpp b/core/fpdfdoc/cpdf_annotlist.cpp
index 8ab99e55d257242068bcb6599f6563eba48d46d5..e055f48d4a214775857561cb19b8572d0b38a8d1 100644
--- a/core/fpdfdoc/cpdf_annotlist.cpp
+++ b/core/fpdfdoc/cpdf_annotlist.cpp
@@ -30,7 +30,7 @@ std::unique_ptr<CPDF_Annot> CreatePopupAnnot(CPDF_Annot* pAnnot,
if (sContents.IsEmpty())
return std::unique_ptr<CPDF_Annot>();
- CPDF_Dictionary* pAnnotDict = new CPDF_Dictionary;
+ CPDF_Dictionary* pAnnotDict = new CPDF_Dictionary(pDocument);
pAnnotDict->SetNameFor("Type", "Annot");
pAnnotDict->SetNameFor("Subtype", "Popup");
pAnnotDict->SetStringFor("T", pParentDict->GetStringFor("T"));
« core/fpdfapi/fpdf_parser/include/cpdf_document.h ('K') | « core/fpdfapi/fpdf_parser/include/cpdf_document.h ('k') | core/fpdfdoc/cpdf_filespec.cpp » ('j') | core/fpdfdoc/include/cpdf_filespec.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698