Use string pools in some dictionaries

core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h

Index: core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h
diff --git a/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h b/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h
index 8ca7e33824b96e1aeeff88240859d96c8c70be50..710290299fb25efeddf3ff676fff6f9dd444398e 100644
--- a/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h
+++ b/core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h
@@ -9,6 +9,7 @@
 
 #include <memory>
 
+#include "core/fxcrt/include/cfx_string_pool_template.h"
 #include "core/fxcrt/include/fx_basic.h"
 
 class CPDF_CryptoHandler;
@@ -21,6 +22,7 @@ class IFX_FileRead;
 class CPDF_SyntaxParser {
  public:
   CPDF_SyntaxParser();
+  CPDF_SyntaxParser(CFX_ByteStringPool* pPool);
   ~CPDF_SyntaxParser();
 
   void InitParser(IFX_FileRead* pFileAccess, uint32_t HeaderOffset);
@@ -64,7 +66,6 @@ class CPDF_SyntaxParser {
   static int s_CurrentRecursionDepth;
 
   uint32_t GetDirectNum();
-
   FX_BOOL GetNextChar(uint8_t& ch);
   FX_BOOL GetCharAtBackward(FX_FILESIZE pos, uint8_t& ch);
   void GetNextWordInternal(bool* bIsNumber);
@@ -80,6 +81,8 @@ class CPDF_SyntaxParser {
                           uint32_t objnum,
                           uint32_t gennum);
 
+  CFX_ByteString MaybeIntern(const CFX_ByteString& str);
+
   FX_FILESIZE m_Pos;
   int m_MetadataObjnum;
   IFX_FileRead* m_pFileAccess;
@@ -91,6 +94,7 @@ class CPDF_SyntaxParser {
   std::unique_ptr<CPDF_CryptoHandler> m_pCryptoHandler;
   uint8_t m_WordBuffer[257];
   uint32_t m_WordSize;
+  CFX_ByteStringPool* m_pPool;

[dsinclair, 2016/09/19 13:24:34]

add a // Not owned. comment

[Tom Sepez, 2016/09/19 18:24:59]

Made CFX_ByteStringPool* const m_pPool; which is even better than a comment.

 };
 
 #endif  // CORE_FPDFAPI_FPDF_PARSER_CPDF_SYNTAX_PARSER_H_