Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove useless member Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index 80388538b715517f25242504f6962b4b520e8533..88038d2934e68b2cfe03dd33e7601bce9ab10819 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -5141,7 +5141,7 @@ sub JSValueToNative
if ($type eq "any" || IsCallbackFunctionType($type)) {
AddToImplIncludes("bindings/v8/ScriptValue.h");
- return "ScriptValue($value)";
+ return "ScriptValue($value, $getIsolate)";
}
if ($type eq "Promise") {
@@ -5155,7 +5155,7 @@ sub JSValueToNative
if ($type eq "MediaQueryListListener") {
AddToImplIncludes("core/css/MediaQueryListListener.h");
- return "MediaQueryListListener::create(" . $value . ")";
+ return "MediaQueryListListener::create(ScriptValue(" . $value . ", $getIsolate))";
}
if ($type eq "EventTarget") {

Powered by Google App Engine
This is Rietveld 408576698