Source/bindings/tests/results/V8TestMediaQueryListListener.cpp - Issue 23450039: Pass isolate to ScriptValue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestMediaQueryListListener.cpp

Issue 23450039: Pass isolate to ScriptValue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Remove useless member Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/tests/results/V8TestMediaQueryListListener.cpp

diff --git a/Source/bindings/tests/results/V8TestMediaQueryListListener.cpp b/Source/bindings/tests/results/V8TestMediaQueryListListener.cpp

index 20509209d1c0ed434f56e132481481dc0560b5a9..80706ecbaf4d1345f149a2233ff09b17e1fd4bae 100644

--- a/Source/bindings/tests/results/V8TestMediaQueryListListener.cpp

+++ b/Source/bindings/tests/results/V8TestMediaQueryListListener.cpp

@@ -68,7 +68,7 @@ static void methodMethod(const v8::FunctionCallbackInfo<v8::Value>& args)

return;

}

TestMediaQueryListListener* imp = V8TestMediaQueryListListener::toNative(args.Holder());

- V8TRYCATCH_VOID(RefPtr<MediaQueryListListener>, listener, MediaQueryListListener::create(args[0]));

+ V8TRYCATCH_VOID(RefPtr<MediaQueryListListener>, listener, MediaQueryListListener::create(ScriptValue(args[0], args.GetIsolate())));

imp->method(listener);

return;