Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2337363003: Create boilerplate for task-page (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
git@github.com:luci/luci-py@refactor-task
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Create boilerplate for task-page At this point, there is still nothing to display, but we are close to that point. BUG=631047 Committed: https://github.com/luci/luci-py/commit/22a10797daa695be81e8e538aae9cc7b36cdd205

Patch Set 1 #

Patch Set 2 : Add to elements #

Patch Set 3 : Tweak page title #

Patch Set 4 : rebase #

Total comments: 8

Patch Set 5 : Address whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -54 lines) Patch
M appengine/swarming/elements/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M appengine/swarming/elements/Makefile View 1 chunk +5 lines, -0 lines 0 comments Download
M appengine/swarming/elements/build/elements.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/elements.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A appengine/swarming/elements/res/imp/taskpage/task-page.html View 1 2 3 4 1 chunk +93 lines, -0 lines 0 comments Download
A appengine/swarming/elements/res/imp/taskpage/task-page-data.html View 1 2 3 4 1 chunk +153 lines, -0 lines 0 comments Download
A + appengine/swarming/elements/res/imp/taskpage/task-page-demo.html View 5 chunks +21 lines, -49 lines 0 comments Download
A + appengine/swarming/templates/public_task_index.html View 1 2 2 chunks +6 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
kjlubick
4 years, 3 months ago (2016-09-14 19:44:30 UTC) #3
jcgregorio
LGTM, modulo the spacing nits. https://codereview.chromium.org/2337363003/diff/60001/appengine/swarming/elements/res/imp/taskpage/task-page-data.html File appengine/swarming/elements/res/imp/taskpage/task-page-data.html (right): https://codereview.chromium.org/2337363003/diff/60001/appengine/swarming/elements/res/imp/taskpage/task-page-data.html#newcode41 appengine/swarming/elements/res/imp/taskpage/task-page-data.html:41: 1 blank line. https://codereview.chromium.org/2337363003/diff/60001/appengine/swarming/elements/res/imp/taskpage/task-page.html ...
4 years, 3 months ago (2016-09-20 12:35:19 UTC) #4
kjlubick
https://codereview.chromium.org/2337363003/diff/60001/appengine/swarming/elements/res/imp/taskpage/task-page-data.html File appengine/swarming/elements/res/imp/taskpage/task-page-data.html (right): https://codereview.chromium.org/2337363003/diff/60001/appengine/swarming/elements/res/imp/taskpage/task-page-data.html#newcode41 appengine/swarming/elements/res/imp/taskpage/task-page-data.html:41: On 2016/09/20 at 12:35:19, jcgregorio wrote: > 1 blank ...
4 years, 3 months ago (2016-09-20 13:27:33 UTC) #5
KevinL
lgtm
4 years, 3 months ago (2016-09-20 13:48:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337363003/80001
4 years, 3 months ago (2016-09-20 13:48:54 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 13:51:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/22a10797daa695be81e8e538aae9cc7b36cdd205

Powered by Google App Engine
This is Rietveld 408576698