Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2344793002: Allow app banners to trigger on 0 engagement. (Closed)

Created:
4 years, 3 months ago by dominickn
Modified:
4 years, 3 months ago
Reviewers:
benwells
CC:
chromium-reviews, dominickn+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow app banners to trigger on 0 engagement. BUG=616322 Committed: https://crrev.com/0a388886e07037d76be02dbf656cc1eb35bb681d Cr-Commit-Position: refs/heads/master@{#418787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/banners/app_banner_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/banners/app_banner_settings_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
dominickn
PTAL.
4 years, 3 months ago (2016-09-15 03:58:22 UTC) #4
benwells
lgtm
4 years, 3 months ago (2016-09-15 04:02:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2344793002/1
4 years, 3 months ago (2016-09-15 05:06:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-15 05:10:05 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 05:14:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a388886e07037d76be02dbf656cc1eb35bb681d
Cr-Commit-Position: refs/heads/master@{#418787}

Powered by Google App Engine
This is Rietveld 408576698