Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2344793002: Allow app banners to trigger on 0 engagement. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 48c676a2f8f0606188ba6003ee20d2fa0ca382dd..2d75eed74428ec31a55b5ba55ac10f448326a0fd 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -363,8 +363,12 @@ void AppBannerManager::DidFinishLoad(
load_finished_ = true;
validated_url_ = validated_url;
+ // Start the pipeline immediately if we aren't using engagement, or if 0
+ // engagement is required.
if (!AppBannerSettingsHelper::ShouldUseSiteEngagementScore() ||
- banner_request_queued_) {
+ banner_request_queued_ ||
+ AppBannerSettingsHelper::HasSufficientEngagement(0)) {
+ SiteEngagementObserver::Observe(nullptr);
banner_request_queued_ = false;
RequestAppBanner(validated_url, false /* is_debug_mode */);
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_settings_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698