Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: chrome/browser/banners/app_banner_settings_helper.cc

Issue 2344793002: Allow app banners to trigger on 0 engagement. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_settings_helper.cc
diff --git a/chrome/browser/banners/app_banner_settings_helper.cc b/chrome/browser/banners/app_banner_settings_helper.cc
index 2dfaf0ce67126a7e444a46a863cfeea426f94fbe..75e0f03c7c05edb79d151405ab9ac7ad85fc98aa 100644
--- a/chrome/browser/banners/app_banner_settings_helper.cc
+++ b/chrome/browser/banners/app_banner_settings_helper.cc
@@ -147,7 +147,7 @@ void UpdateSiteEngagementToTrigger() {
double total_engagement = -1;
if (base::StringToDouble(total_param, &total_engagement) &&
- total_engagement > 0) {
+ total_engagement >= 0) {
AppBannerSettingsHelper::SetTotalEngagementToTrigger(total_engagement);
}
}
« no previous file with comments | « chrome/browser/banners/app_banner_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698