Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2344563002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive

Created:
4 years, 3 months ago by kouhei (in TOK)
Modified:
4 years, 1 month ago
Reviewers:
haraken, hiroshige, Yuki
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the lifetime hack in ImageLoader where it keeps its assoc element alive {HTML,SVG}ImageElement keeps itself alive by {HTML,SVG}ImageElement::hasPendingActivity BUG=383741

Patch Set 1 #

Patch Set 2 : SVGImageElement::hasPendingActivity #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -62 lines) Patch
M third_party/WebKit/Source/core/loader/ImageLoader.h View 3 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 7 chunks +0 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.h View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGImageElement.idl View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
kouhei (in TOK)
warito scary
4 years, 3 months ago (2016-09-14 16:49:27 UTC) #4
haraken
LGTM
4 years, 3 months ago (2016-09-15 01:06:10 UTC) #7
hiroshige
Great, but some tests are failing consistently on the bots.
4 years, 3 months ago (2016-09-15 04:32:12 UTC) #9
kouhei (in TOK)
4 years, 3 months ago (2016-09-15 09:08:28 UTC) #10
On 2016/09/15 04:32:12, hiroshige wrote:
> Great, but some tests are failing consistently on the bots.

Actually I want your input here, the failing tests are from the GC crash tests.
I'm not sure if we really need to match the behavior here, or simply remove the
tests.
See:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/loader/Im...

Powered by Google App Engine
This is Rietveld 408576698