third_party/WebKit/Source/core/svg/SVGImageElement.cpp - Issue 2344563002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGImageElement.cpp

Issue 2344563002: Remove the lifetime hack in ImageLoader where it keeps its assoc element alive

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGImageElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGImageElement.cpp b/third_party/WebKit/Source/core/svg/SVGImageElement.cpp

index 079e9f6c1472b3e02869e7b5df6d3ceb89df71ee..9d4f4b383aae56b4e42b626052506fe7a7a61d82 100644

--- a/third_party/WebKit/Source/core/svg/SVGImageElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGImageElement.cpp

@@ -31,6 +31,7 @@ namespace blink {

inline SVGImageElement::SVGImageElement(Document& document)

: SVGGraphicsElement(SVGNames::imageTag, document)

, SVGURIReference(this)

+ , ActiveScriptWrappable(this)

, m_x(SVGAnimatedLength::create(this, SVGNames::xAttr, SVGLength::create(SVGLengthMode::Width)))

, m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(SVGLengthMode::Height)))

, m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::create(SVGLengthMode::Width)))