Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2344513002: PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS (Closed)

Created:
4 years, 3 months ago by Jim Stichnoth
Modified:
4 years, 3 months ago
Reviewers:
Derek Schuff, John
CC:
native-client-reviews_googlegroups.com, capn_google.com, jaydeep.patil
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS This pulls in the following Subzero changes: 038a9b9: (capn@google.com) Remove instructions instead of attempting to delete them. d329766: (jaydeep.patil@imgtec.com) [SubZero] Implement GP to/from FP moves for MIPS bcf2a51: (stichnot@chromium.org) Subzero: Fix ODR errors in the g++ build. BUG=swiftshader:8 TEST= PNaCl toolchain trybots R=dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/b6c1741002bf4fd60702839329222394b26c2003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pnacl/COMPONENT_REVISIONS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
4 years, 3 months ago (2016-09-14 13:26:34 UTC) #3
Derek Schuff
lgtm
4 years, 3 months ago (2016-09-14 15:07:57 UTC) #4
Jim Stichnoth
Thanks! I will go ahead and land this mostly to see if it fixes the ...
4 years, 3 months ago (2016-09-14 15:33:31 UTC) #5
Jim Stichnoth
4 years, 3 months ago (2016-09-14 15:34:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6c1741002bf4fd60702839329222394b26c2003 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698