Subzero: Fix SUBZERO_REVISION in production builds.

Subzero: Fix SUBZERO_REVISION in production builds.

In production autoconf builds (which are the builds that matter), the SUBZERO_REVISION was being calculated based on git history of the top-level native_client repo, rather than the pnacl-subzero repo.

BUG= none
R=jpp@chromium.org, kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ca7a36739da48c5a945ad9701c2c331536734ee5

[Jim Stichnoth, 2016-09-14 14:00:31]

Description was changed from

==========
Subzero: Fix SUBZERO_REVISION in production builds.

BUG= none
==========

to

==========
Subzero: Fix SUBZERO_REVISION in production builds.

In production autoconf builds (which are the builds that matter), the
SUBZERO_REVISION was being calculated based on git history of the top-level
native_client repo, rather than the pnacl-subzero repo.

BUG= none
==========

[Jim Stichnoth, 2016-09-14 14:00:31]

stichnot@chromium.org changed reviewers:
+ dschuff@chromium.org, eholk@chromium.org, jpp@chromium.org,
kschimpf@google.com

[John, 2016-09-14 14:04:24]

lgtm

[Jim Stichnoth, 2016-09-14 15:48:00]

I found a cleaner way of changing the working directory:

  git -C <dir> ...

PTAL.

[Karl, 2016-09-14 15:50:52]

lgtm

[Jim Stichnoth, 2016-09-14 18:07:32]

Description was changed from

==========
Subzero: Fix SUBZERO_REVISION in production builds.

In production autoconf builds (which are the builds that matter), the
SUBZERO_REVISION was being calculated based on git history of the top-level
native_client repo, rather than the pnacl-subzero repo.

BUG= none
==========

to

==========
Subzero: Fix SUBZERO_REVISION in production builds.

In production autoconf builds (which are the builds that matter), the
SUBZERO_REVISION was being calculated based on git history of the top-level
native_client repo, rather than the pnacl-subzero repo.

BUG= none
R=jpp@chromium.org, kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-09-14 18:07:33]

Committed patchset #2 (id:20001) manually as
ca7a36739da48c5a945ad9701c2c331536734ee5 (presubmit successful).

[Jim Stichnoth, 2016-09-14 21:33:40]

Hmm, for the record, whatever version of git is on the Windows builder, doesn't
like the "-C" option:

Unknown option: -C
usage: git [--version] [--exec-path[=<path>]] [--html-path] [--man-path]
[--info-path]
           [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           [-c name=value] [--help]
           <command> [<args>]

The result is that SUBZERO_REVISION is always "_" on Windows.

That's probably OK for now.  If a user reports a bug against the latest
PNaCl/Subzero component, we can extract the SUBZERO_REVISION from the Linux
build even if the user was on Windows.  The purpose of SUBZERO_REVISION is to
make it easier to roll back to the precise git revision and use that as a
starting point for debugging.

[John, 2016-09-15 14:04:56]

lgtm