Add const to BindStateBase to align RefCounted constness

Add const to BindStateBase to align to RefCounted constness

Committed: https://crrev.com/30e0c31970dd7d31877f455d8cdb65c8e35f880f
Cr-Commit-Position: refs/heads/master@{#420005}

[tzik, 2016-09-16 11:54:56]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 11:55:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 13:07:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 13:07:54]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tzik, 2016-09-20 06:49:23]

Description was changed from

==========
Add const to BindStateBase to align RefCounted constness
==========

to

==========
Add const to BindStateBase to align to RefCounted constness
==========

[tzik, 2016-09-20 06:49:23]

tzik@chromium.org changed reviewers:
+ yutak@chromium.org

[tzik, 2016-09-20 06:49:33]

PTAL

[Yuta Kitamura, 2016-09-20 10:04:21]

https://codereview.chromium.org/2344143002/diff/1/base/callback_internal.h
File base/callback_internal.h (right):

https://codereview.chromium.org/2344143002/diff/1/base/callback_internal.h#ne...
base/callback_internal.h:55: void Release() const;
I'm not sure adding const to these is legit. In my plain understanding
they modify the refcount, so they shouldn't be const.

[tzik, 2016-09-20 10:54:30]

https://codereview.chromium.org/2344143002/diff/1/base/callback_internal.h
File base/callback_internal.h (right):

https://codereview.chromium.org/2344143002/diff/1/base/callback_internal.h#ne...
base/callback_internal.h:55: void Release() const;
On 2016/09/20 10:04:21, Yuta Kitamura wrote:
> I'm not sure adding const to these is legit. In my plain understanding
> they modify the refcount, so they shouldn't be const.

The refcount is not a state of the instance, but a shared state of the strong
references to the instance. Even on a const object, IMO, we should be able to
make a strong reference to it, without modifying the main part of the object.

Also, this is needed to make BindStateBase be a subclass of
RefCountedThreadSafe. That will remove the manual refcount handling in
BindStateBase, and simplify the class.

[Yuta Kitamura, 2016-09-21 06:01:36]

lgtm

https://codereview.chromium.org/2344143002/diff/1/base/callback_internal.h
File base/callback_internal.h (right):

https://codereview.chromium.org/2344143002/diff/1/base/callback_internal.h#ne...
base/callback_internal.h:55: void Release() const;
On 2016/09/20 10:54:30, tzik wrote:
> On 2016/09/20 10:04:21, Yuta Kitamura wrote:
> > I'm not sure adding const to these is legit. In my plain understanding
> > they modify the refcount, so they shouldn't be const.
> 
> The refcount is not a state of the instance, but a shared state of the strong
> references to the instance. Even on a const object, IMO, we should be able to
> make a strong reference to it, without modifying the main part of the object.
> 
> Also, this is needed to make BindStateBase be a subclass of
> RefCountedThreadSafe. That will remove the manual refcount handling in
> BindStateBase, and simplify the class.

Ah okay, this lets us refcount const objects, right?

[tzik, 2016-09-21 06:11:18]

On 2016/09/21 06:01:36, Yuta Kitamura wrote:
> lgtm
> 
> https://codereview.chromium.org/2344143002/diff/1/base/callback_internal.h
> File base/callback_internal.h (right):
> 
>
https://codereview.chromium.org/2344143002/diff/1/base/callback_internal.h#ne...
> base/callback_internal.h:55: void Release() const;
> On 2016/09/20 10:54:30, tzik wrote:
> > On 2016/09/20 10:04:21, Yuta Kitamura wrote:
> > > I'm not sure adding const to these is legit. In my plain understanding
> > > they modify the refcount, so they shouldn't be const.
> > 
> > The refcount is not a state of the instance, but a shared state of the
strong
> > references to the instance. Even on a const object, IMO, we should be able
to
> > make a strong reference to it, without modifying the main part of the
object.
> > 
> > Also, this is needed to make BindStateBase be a subclass of
> > RefCountedThreadSafe. That will remove the manual refcount handling in
> > BindStateBase, and simplify the class.
> 
> Ah okay, this lets us refcount const objects, right?

Right.

[tzik, 2016-09-21 06:11:27]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-09-21 06:12:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 08:07:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 08:08:55]

Description was changed from

==========
Add const to BindStateBase to align to RefCounted constness
==========

to

==========
Add const to BindStateBase to align to RefCounted constness

Committed: https://crrev.com/30e0c31970dd7d31877f455d8cdb65c8e35f880f
Cr-Commit-Position: refs/heads/master@{#420005}
==========

[commit-bot: I haz the power, 2016-09-21 08:08:56]

Patchset 1 (id:??) landed as
https://crrev.com/30e0c31970dd7d31877f455d8cdb65c8e35f880f
Cr-Commit-Position: refs/heads/master@{#420005}