Make BindStateBase RefCountedThreadSafe

Make BindStateBase RefCountedThreadSafe

Since RefCountedThreadSafe no longer requires virtual destructor, being
RefCountedThreadSafe doesn't increase the binary size significantly.
This CL replaces the custom refcount in BindStateBase with
RefCountedThreadSafe.

[tzik, 2016-09-16 11:54:22]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 11:54:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 13:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 13:03:04]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tzik, 2016-09-21 16:12:52]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 16:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-09-21 16:20:52]

Description was changed from

==========
Make BindStateBase RefCountedThreadSafe
==========

to

==========
Make BindStateBase RefCountedThreadSafe

Since RefCountedThreadSafe no longer requires virtual destructor, being
RefCountedThreadSafe doesn't increase the binary size significantly.
This CL replaces the custom refcount in BindStateBase with
RefCountedThreadSafe.
==========

[tzik, 2016-09-21 16:20:52]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2016-09-21 16:33:43]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 16:34:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-09-21 16:46:48]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[tzik, 2016-09-21 16:47:11]

PTAL

[commit-bot: I haz the power, 2016-09-21 16:47:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 18:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:24:12]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[dcheng, 2016-09-21 22:07:50]

https://codereview.chromium.org/2340153004/diff/60001/base/callback_internal.h
File base/callback_internal.h (right):

https://codereview.chromium.org/2340153004/diff/60001/base/callback_internal....
base/callback_internal.h:44: static void Destruct(const BindStateBase* obj);
Does it make sense to inline the definition in the header? I'm wondering if it
will have any binary size impact.

https://codereview.chromium.org/2340153004/diff/60001/base/callback_internal....
base/callback_internal.h:68: friend struct BindState;
It feels a bit funny that we have to friend both the traits object and our
derived class.

https://codereview.chromium.org/2340153004/diff/60001/base/callback_internal....
base/callback_internal.h:70: friend struct base::FakeBindState2;
I'm a bit sad about having to friend these test only structs. I wonder... can
the tests just store this thing in a scoped_refptr?

[dcheng, 2016-09-21 22:08:02]

Also, what is the overall size impact of this CL?