Remove ref_counted.cc

Remove ref_counted.cc

This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc
to the header as inline functions for smaller binary.

RefCountedThreadSafe methods in ref_counted.cc are too small to have
non-inlined function. Inlining them to the caller reduces the stripped
binary size of Chromium on Linux by 84kB, since the binary size the
function body are even smaller than the binary size of the function
call itself.

Committed: https://crrev.com/2c5c70912ccd80e712b18b4bf39f6da3d41e8847
Cr-Commit-Position: refs/heads/master@{#419973}

[tzik, 2016-09-16 10:43:33]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 10:43:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-09-16 10:54:29]

Description was changed from

==========
Remove ref_counted.cc

BUG=
==========

to

==========
Remove ref_counted.cc

This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc
to the header as inline functions for smaller binary.

RefCountedThreadSafe methods in ref_counted.cc are too small to have
non-inlined function. Inlining them to the caller reduces the stripped
binary size of Chromium on Linux by 84kB, since the binary size the
function body are even smaller than the binary size of the function
call itself.
==========

[tzik, 2016-09-16 10:56:45]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2016-09-16 10:56:46]

PTAL

[commit-bot: I haz the power, 2016-09-16 12:04:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 12:04:50]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[dcheng, 2016-09-16 19:23:37]

LGTM!

Btw, do you have a process by which you're finding these? I wonder if we can
write a binary analysis tool to help find these more easily...

[tzik, 2016-09-20 06:36:20]

On 2016/09/16 19:23:37, dcheng wrote:
> LGTM!
> 
> Btw, do you have a process by which you're finding these? I wonder if we can
> write a binary analysis tool to help find these more easily...

That's just a result of a chance. I made a WIP CL to use scoped_refptr in
CallbackBase, but that gains the binary size significantly, over 500kB. While
dealing with it, I found scoped_refptr takes large part of the size gain.

Assuming a function worth considering to inline is smaller than 20 bytes and is
called more than 10k times, I found no function other than RefCountedThreadSafe
and Callback related ones.

[tzik, 2016-09-20 06:36:27]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2016-09-20 06:36:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 08:14:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 08:14:23]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tzik, 2016-09-20 09:10:42]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 09:11:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 10:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 10:31:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tzik, 2016-09-20 11:47:36]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 11:47:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 13:37:14]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-09-21 04:37:54]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-09-21 04:37:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2345013003/#ps60001
(title: "revert _EXPORT part")

[commit-bot: I haz the power, 2016-09-21 04:38:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 04:43:41]

Description was changed from

==========
Remove ref_counted.cc

This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc
to the header as inline functions for smaller binary.

RefCountedThreadSafe methods in ref_counted.cc are too small to have
non-inlined function. Inlining them to the caller reduces the stripped
binary size of Chromium on Linux by 84kB, since the binary size the
function body are even smaller than the binary size of the function
call itself.
==========

to

==========
Remove ref_counted.cc

This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc
to the header as inline functions for smaller binary.

RefCountedThreadSafe methods in ref_counted.cc are too small to have
non-inlined function. Inlining them to the caller reduces the stripped
binary size of Chromium on Linux by 84kB, since the binary size the
function body are even smaller than the binary size of the function
call itself.
==========

[commit-bot: I haz the power, 2016-09-21 04:43:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-21 04:45:46]

Description was changed from

==========
Remove ref_counted.cc

This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc
to the header as inline functions for smaller binary.

RefCountedThreadSafe methods in ref_counted.cc are too small to have
non-inlined function. Inlining them to the caller reduces the stripped
binary size of Chromium on Linux by 84kB, since the binary size the
function body are even smaller than the binary size of the function
call itself.
==========

to

==========
Remove ref_counted.cc

This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc
to the header as inline functions for smaller binary.

RefCountedThreadSafe methods in ref_counted.cc are too small to have
non-inlined function. Inlining them to the caller reduces the stripped
binary size of Chromium on Linux by 84kB, since the binary size the
function body are even smaller than the binary size of the function
call itself.

Committed: https://crrev.com/2c5c70912ccd80e712b18b4bf39f6da3d41e8847
Cr-Commit-Position: refs/heads/master@{#419973}
==========

[commit-bot: I haz the power, 2016-09-21 04:45:46]

Patchset 4 (id:??) landed as
https://crrev.com/2c5c70912ccd80e712b18b4bf39f6da3d41e8847
Cr-Commit-Position: refs/heads/master@{#419973}

[agrieve, 2016-09-22 15:37:00]

On 2016/09/21 04:45:46, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/2c5c70912ccd80e712b18b4bf39f6da3d41e8847
> Cr-Commit-Position: refs/heads/master@{#419973}

FYI - this commit *grew* libchrome.so on Android by ~50kb.
https://chromeperf.appspot.com/report?sid=f8be4459943df7093c2c0cdfa83b9350c74...

I'd guess if there was no other motivation than code size, we should revert it.

[agrieve, 2016-09-26 18:17:44]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2366323003/ by agrieve@chromium.org.

The reason for reverting is: Increased Android .so by 50kb rather than shrinking
it..