Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: BOOL*_BOOL -> BOOL* Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index 047d9479ce50348f3498fee68af7bef976bea561..46b011633307efbfe35c45d7f6cdf857d2a4e7a0 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -435,14 +435,14 @@ def v8_value_to_local_cpp_value(idl_type, extended_attributes, v8_value, variabl
cpp_value = v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, index)
args = [this_cpp_type, variable_name, cpp_value]
if idl_type.base_type == 'DOMString' and not idl_type.array_or_sequence_type:
- v8trycatch_void = 'V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID'
+ macro = 'TOSTRING_VOID'
elif idl_type.is_integer_type:
- v8trycatch_void = 'V8TRYCATCH_EXCEPTION_VOID'
+ macro = 'TONATIVE_VOID_EXCEPTIONSTATE'
args.append('exceptionState')
else:
- v8trycatch_void = 'V8TRYCATCH_VOID'
+ macro = 'TONATIVE_VOID'
- return '%s(%s)' % (v8trycatch_void, ', '.join(args))
+ return '%s(%s)' % (macro, ', '.join(args))
IdlType.v8_value_to_local_cpp_value = v8_value_to_local_cpp_value
IdlUnionType.v8_value_to_local_cpp_value = v8_value_to_local_cpp_value
« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698