Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: Source/bindings/templates/interface.cpp

Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: BOOL*_BOOL -> BOOL* Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/interface.cpp
diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp
index 964ce305a72a11ec4d3feb124c8f000ce8e6cae7..418301c4bbeee8f422fc6f2595dfaded9a5f74e7 100644
--- a/Source/bindings/templates/interface.cpp
+++ b/Source/bindings/templates/interface.cpp
@@ -345,7 +345,7 @@ static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value>
{% endif %}
{{cpp_class}}* impl = {{v8_class}}::toNative(info.Holder());
{# v8_value_to_local_cpp_value('DOMString', 'name', 'propertyName') #}
- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyName, name);
+ TOSTRING_VOID(V8StringResource<>, propertyName, name);
{{setter.v8_value_to_local_cpp_value}};
{% if setter.has_exception_state %}
v8::String::Utf8Value namedProperty(name);
@@ -626,13 +626,13 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)
return;
}
- V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, type, info[0]);
+ TOSTRING_VOID(V8StringResource<>, type, info[0]);
{% for attribute in any_type_attributes %}
v8::Local<v8::Value> {{attribute.name}};
{% endfor %}
{{cpp_class}}Init eventInit;
if (info.Length() >= 2) {
- V8TRYCATCH_VOID(Dictionary, options, Dictionary(info[1], isolate));
+ TONATIVE_VOID(Dictionary, options, Dictionary(info[1], isolate));
if (!initialize{{cpp_class}}(eventInit, options, exceptionState, info)) {
exceptionState.throwIfNeeded();
return;
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698