Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 234403004: Rename V8TRYCATCH_* macros in v8/V8BindingMacros.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: BOOL*_BOOL -> BOOL* Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index d6b98f2febdc4c508507f3ef1475529c76830a0d..94f22f33814e7d2d9871f4d72c35767929293390 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -249,16 +249,17 @@ def v8_value_to_local_cpp_value(argument, index):
name = argument.name
if argument.is_variadic:
vector_type = v8_types.cpp_ptr_type('Vector', 'HeapVector', idl_type.gc_type)
- return 'V8TRYCATCH_VOID({vector_type}<{cpp_type}>, {name}, toNativeArguments<{cpp_type}>(info, {index}))'.format(
- cpp_type=idl_type.cpp_type, name=name, index=index, vector_type=vector_type)
+ return 'TONATIVE_VOID({vector_type}<{cpp_type}>, {name}, toNativeArguments<{cpp_type}>(info, {index}))'.format(
+ vector_type=vector_type, cpp_type=idl_type.cpp_type, name=name,
+ index=index)
# [Default=NullString]
if (argument.is_optional and idl_type.name == 'String' and
extended_attributes.get('Default') == 'NullString'):
v8_value = 'argumentOrNull(info, %s)' % index
else:
v8_value = 'info[%s]' % index
- return idl_type.v8_value_to_local_cpp_value(argument.extended_attributes,
- v8_value, name, index=index)
+ return idl_type.v8_value_to_local_cpp_value(extended_attributes, v8_value,
+ name, index=index)
################################################################################
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698