Fix under-invalidation of media slider thumb when network state changes

Fix under-invalidation of media slider thumb when network state changes

When we invalidate a media control, we need to invalidate the whole
subtree because not only the top-level layout object but also the
descendants may paint differently.

BUG=645225
TEST=paint/invalidation/video-play-no-source-under-invalidation.html

Committed: https://crrev.com/b6f6dab6bacc9029e75e21df0b4be04783e675c6
Cr-Commit-Position: refs/heads/master@{#418750}

[Xianzhu, 2016-09-14 23:14:06]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 23:14:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-15 00:07:14]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-09-15 00:09:02]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 00:09:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-09-15 00:25:13]

lgtm

https://codereview.chromium.org/2343713003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/video-play-no-source-under-invalidation-expected.txt
(right):

https://codereview.chromium.org/2343713003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/video-play-no-source-under-invalidation-expected.txt:1:
Tests playing video with invalid source with paintUnderInvalidationChecking
enabled. Passes of no under-invalidation reported.
same nit as above

https://codereview.chromium.org/2343713003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/video-play-no-source-under-invalidation.html
(right):

https://codereview.chromium.org/2343713003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/video-play-no-source-under-invalidation.html:9:
Passes of no under-invalidation reported.
nit: s/of/if/

[Xianzhu, 2016-09-15 00:31:59]

https://codereview.chromium.org/2343713003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/video-play-no-source-under-invalidation-expected.txt
(right):

https://codereview.chromium.org/2343713003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/video-play-no-source-under-invalidation-expected.txt:1:
Tests playing video with invalid source with paintUnderInvalidationChecking
enabled. Passes of no under-invalidation reported.
On 2016/09/15 00:25:13, chrishtr wrote:
> same nit as above

Done.

https://codereview.chromium.org/2343713003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/paint/invalidation/video-play-no-source-under-invalidation.html
(right):

https://codereview.chromium.org/2343713003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/paint/invalidation/video-play-no-source-under-invalidation.html:9:
Passes of no under-invalidation reported.
On 2016/09/15 00:25:13, chrishtr wrote:
> nit: s/of/if/

Done.

[Xianzhu, 2016-09-15 00:32:21]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-09-15 00:32:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2343713003/#ps40001
(title: "-")

[commit-bot: I haz the power, 2016-09-15 00:33:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 01:47:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 01:49:54]

Description was changed from

==========
Fix under-invalidation of media slider thumb when network state changes

When we invalidate a media control, we need to invalidate the whole
subtree because not only the top-level layout object but also the
descendants may paint differently.

BUG=645225
TEST=paint/invalidation/video-play-no-source-under-invalidation.html
==========

to

==========
Fix under-invalidation of media slider thumb when network state changes

When we invalidate a media control, we need to invalidate the whole
subtree because not only the top-level layout object but also the
descendants may paint differently.

BUG=645225
TEST=paint/invalidation/video-play-no-source-under-invalidation.html

Committed: https://crrev.com/b6f6dab6bacc9029e75e21df0b4be04783e675c6
Cr-Commit-Position: refs/heads/master@{#418750}
==========

[commit-bot: I haz the power, 2016-09-15 01:49:56]

Patchset 3 (id:??) landed as
https://crrev.com/b6f6dab6bacc9029e75e21df0b4be04783e675c6
Cr-Commit-Position: refs/heads/master@{#418750}