Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2343713003: Fix under-invalidation of media slider thumb when network state changes (Closed)
Patch Set: - Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-unmute-repaint-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 807 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 // Update the controls visibility. 818 // Update the controls visibility.
819 updateVolume(); 819 updateVolume();
820 } 820 }
821 821
822 void MediaControls::invalidate(Element* element) 822 void MediaControls::invalidate(Element* element)
823 { 823 {
824 if (!element) 824 if (!element)
825 return; 825 return;
826 826
827 if (LayoutObject* layoutObject = element->layoutObject()) 827 if (LayoutObject* layoutObject = element->layoutObject())
828 layoutObject->setShouldDoFullPaintInvalidation(); 828 layoutObject->setShouldDoFullPaintInvalidationIncludingNonCompositingDes cendants();
829 } 829 }
830 830
831 void MediaControls::networkStateChanged() 831 void MediaControls::networkStateChanged()
832 { 832 {
833 invalidate(m_playButton); 833 invalidate(m_playButton);
834 invalidate(m_overlayPlayButton); 834 invalidate(m_overlayPlayButton);
835 invalidate(m_muteButton); 835 invalidate(m_muteButton);
836 invalidate(m_fullscreenButton); 836 invalidate(m_fullscreenButton);
837 invalidate(m_downloadButton); 837 invalidate(m_downloadButton);
838 invalidate(m_timeline); 838 invalidate(m_timeline);
(...skipping 28 matching lines...) Expand all
867 visitor->trace(m_enclosure); 867 visitor->trace(m_enclosure);
868 visitor->trace(m_textTrackList); 868 visitor->trace(m_textTrackList);
869 visitor->trace(m_overflowMenu); 869 visitor->trace(m_overflowMenu);
870 visitor->trace(m_overflowList); 870 visitor->trace(m_overflowList);
871 visitor->trace(m_castButton); 871 visitor->trace(m_castButton);
872 visitor->trace(m_overlayCastButton); 872 visitor->trace(m_overlayCastButton);
873 HTMLDivElement::trace(visitor); 873 HTMLDivElement::trace(visitor);
874 } 874 }
875 875
876 } // namespace blink 876 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/platform/android/paint/invalidation/video-unmute-repaint-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698