third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html - Issue 2343713003: Fix under-invalidation of media slider thumb when network state changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html

Issue 2343713003: Fix under-invalidation of media slider thumb when network state changes (Closed)

Patch Set: - Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/media-audio-no-spurious-repaints-expected.txt ('k') | third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html

diff --git a/third_party/WebKit/LayoutTests/media/media-audio-no-spurious-repaints.html b/third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html

similarity index 74%

rename from third_party/WebKit/LayoutTests/media/media-audio-no-spurious-repaints.html

rename to third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html

index 265d553876edb34ed71553f25055b81f3008608e..71aed957dc41e46e0b9bf617a9560df460fae045 100644

--- a/third_party/WebKit/LayoutTests/media/media-audio-no-spurious-repaints.html

+++ b/third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html

@@ -1,7 +1,7 @@

<!doctype html>

<title>Verifies there are no spurious repaints for audio in a video tag.</title>

-<script src="../resources/testharness.js"></script>

-<script src="../resources/testharnessreport.js"></script>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

async_test(function(t) {

@@ -15,7 +15,7 @@ async_test(function(t) {

video.addEventListener('ended', t.step_func(function() {

var layerTree = internals.layerTreeAsText(

document, internals.LAYER_TREE_INCLUDES_PAINT_INVALIDATIONS);

- var repaintRects = JSON.parse(layerTree).children[0].repaintRects;

+ var paintInvalidations = JSON.parse(layerTree).children[0].paintInvalidations;

internals.stopTrackingRepaints(document);

// Manually verify the number of repaints instead of using a repaint

@@ -32,13 +32,13 @@ async_test(function(t) {

' Actual layer tree: ' + layerTree);

});

- assert_between_inclusive(repaintRects.length, minExpected, maxExpected);

- for (var i = 0; i < repaintRects.length; ++i)

- assert_array_equals(repaintRects[i], expectedRect);

+ assert_between_inclusive(paintInvalidations.length, minExpected, maxExpected);

+ for (var i = 0; i < paintInvalidations.length; ++i)

+ assert_array_equals(paintInvalidations[i].rect, expectedRect);

t.done();

}), false);

- video.src = 'content/silence.wav';

+ video.src = '../../media/content/silence.wav';

});

</script>